This repository was archived by the owner on Oct 23, 2024. It is now read-only.
Fix labeled sidebar accessibility #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliewongbandue
approved these changes
Jul 31, 2023
siberry
pushed a commit
that referenced
this pull request
Aug 1, 2023
Co-authored-by: Kyler Berry <kyler.berry@vimeo.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Due to a negative margin for labeled buttons, the blue focus ring is obscurred. This PR adjusts the focus ring for labeled items only so that it is visible again
Screenshots & Recordings
Testing
Easily test on storybook. Select a sidebar item and then press tab. The next item in the sidebar should show a blue focus ring