pod watcher: Add InitialListComplete event #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, the initial list of pods matching the specified label matcher may be empty. In that case, clients may still want to continue initialization. However, the `Continues()` method only provides information about the first full state if there are pod events to attach them to. This change adds a `InitialListComplete` event type that lets a caller figure out when the initial state dump (of `CreatePod` events) is complete even when there are no pods that matched the label-matcher.
sergiosalvatore
approved these changes
Dec 7, 2021
sachinagada
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the initial list of pods matching the specified label
matcher may be empty. In that case, clients may still want to continue
initialization. However, the
Continues()method only providesinformation about the first full state if there are pod events to attach
them to.
This change adds a
InitialListCompleteevent type that lets a callerfigure out when the initial state dump (of
CreatePodevents) iscomplete even when there are no pods that matched the label-matcher.