8000 Change create_connection return type on `floresta-wire/src/p2p_wire/node.rs` by qlrd · Pull Request #502 · vinteumorg/Floresta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change create_connection return type on floresta-wire/src/p2p_wire/node.rs #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

Change create_connection return type on floresta-wire/src/p2p_wire/node.rs #502

merged 1 commit into from
Jun 2, 2025

Conversation

qlrd
Copy link
Contributor
@qlrd qlrd commented May 29, 2025

What is the purpose of this pull request?

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other:

Description

  • Changed the return type of function signature from Option<()> to Result<(), WireError>;
  • adapted the function calls on node.rs, running_node.rs and sync_node.rs;
  • added two new types of errors (NoAddressAvailable and AlreadyConnected) on WireError. enum.

Notes to the reviewers

While developing #465, it was discussed to change the return type of create_connection. This PR follow this discussion.

Author Checklist

  • I've followed the contribution guidelines
  • I've verified one of the following:
    • Ran just pcc (recommended but slower)
    • Ran just lint-features '-- -D warnings' && cargo test --release
    • Confirmed CI passed on my fork
  • I've linked any related issue(s) in the sections above

@Davidson-Souza Davidson-Souza added chore Cleaning, refactoring, reducing complexity code quality Generally improves code readability and maintainability labels May 29, 2025
Davidson-Souza
Davidson-Souza requested changes May 29, 2025
View reviewed changes
@qlrd qlrd force-pushed the fix-create-connection-wire branch from 7ef7ce2 to 81e59e2 Compare May 30, 2025 13:03
Davidson-Souza
Davidson-Souza reviewed May 30, 2025
View reviewed changes
@qlrd
Change create_connection return type on `floresta-wire/src/p2p_wire/n…
2d1ef13 
…ode.rs`

* Changed the return type of function signature from `Option<()>` to
`Result<(), WireError>`;
* adapted the function calls on node.rs, running_node.rs and
sync_node.rs;
* added two new types of errors (NoAddressAvailable and
AlreadyConnected) on WireError enum.
@qlrd qlrd force-pushed the fix-create-connection-wire branch from 81e59e2 to 2d1ef13 Compare May 30, 2025 14:27
@qlrd qlrd requested a review from Davidson-Souza May 30, 2025 14:51
Davidson-Souza
Davidson-Souza approved these changes May 30, 2025
View reviewed changes
Copy link
Collaborator
@Davidson-Souza Davidson-Souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2d1ef13

JoseSK999
JoseSK999 reviewed May 30, 2025
View reviewed changes
JoseSK999
JoseSK999 approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor
@JoseSK999 JoseSK999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2d1ef13

@Davidson-Souza Davidson-Souza merged commit e01c7e3 into vinteumorg:master Jun 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Davidson-Souza Davidson-Souza Davidson-Souza approved these changes

@JoseSK999 JoseSK999 JoseSK999 approved these changes

Assignees
No one assigned
Labels
chore Cleaning, refactoring, reducing complexity code quality Generally improves code readability and maintainability
Projects
None yet
Milestone
No milestone
Dev 39CE elopment

Successfully merging this pull request may close these issues.
3 participants
@qlrd @Davidson-Souza @JoseSK999
0