fuzz: FlatChainstore targets #529
Open
+530
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1834fc8 to
3f9f3ab
Compare
brunoerg
reviewed
Jun 20, 2025
brunoerg
reviewed
Jun 20, 2025
brunoerg
reviewed
Jun 20, 2025
This commit adds three fuzz targets for `FlatChainstore`, that makes sure our code memory access is sane. We insert, retrieve headers and reorg the chain to stress multiple code paths and check their soundness.
3f9f3ab to
b58e555
Compare
|
@brunoerg removed the non-determinism and added the targets to |
brunoerg
reviewed
Jun 26, 2025
|
|
||
| // Create a temporary directory for our chainstore | ||
| let mut id: [u8; 4] = [0; 4]; | ||
| id.copy_from_slice(&data[0..4]); |
There was a problem hiding this comment.
It doesn't make sense that way it is playing with data. Instead of consuming it, it's simply accessing it. Note that it's using the same part of data in different places here.
brunoerg
reviewed
Jun 26, 2025
| }; | ||
|
|
||
| // Initialize the chainstore | ||
| let mut store = match FlatChainStore::new(config) { |
88AC
There was a problem hiding this comment.
This is creating a FlatChainStore from a simple FlatChainStoreConfig (and static?), so we can surely expect it to succeed. In this case, it makes sense to crash when Err?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
This commit adds three fuzz targets for
FlatChainstore, that makes sure our code memory access is sane. We insert, retrieve headers and reorg the chain to stress multiple code paths and check their soundness.PSA: These targets were generated by A.I. O.o I was testing some A.I. tool and the end result was actually great, so I've decided to fix some minor problems I've found and make a PR with it.