8000 just: don't call black in `check` mode by Davidson-Souza · Pull Request #540 · vinteumorg/Floresta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

just: don't call black in check mode #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

just: don't call black in check mode #540

merged 1 commit into from
Jun 26, 2025

Conversation

Davidson-Souza
Copy link
Collaborator

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other: justfile

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other: justfile

Description

The lint* receipts are meant to fix you code, not check whether it's well formatted. However, black (the python linter) is called with --check, which only yells at you if there's something wrong.

This commit fixes this by removing this paramenter. I'm also adding the python lint to other receipts like pcc and lint.

@Davidson-Souza
just: don't call black in check mode
5e99ce3 
The `lint*` receipts are meant to fix you code, not check whether it's
well formatted. However, black (the python linter) is called with
`--check`, which only yells at you if there's something wrong.

This commit fixes this by removing this paramenter. I'm also adding
the python lint to other receipts like `pcc` and `lint`.
@Davidson-Souza Davidson-Souza added the lint This issue or PR relates to code style and linting label Jun 26, 2025
@Davidson-Souza Davidson-Souza mentioned this pull request Jun 26, 2025
Merged
15 tasks
JoseSK999
JoseSK999 approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor
@JoseSK999 JoseSK999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5e99ce3

@Davidson-Souza Davidson-Souza merged commit e41ad5e into vinteumorg:master Jun 26, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseSK999 JoseSK999 JoseSK999 approved these changes

Assignees
No one assigned
Labels
lint This issue or PR relates to code style and linting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Davidson-Souza @JoseSK999
0