8000 Fix nix flakes check by JoseSK999 · Pull Request #544 · vinteumorg/Floresta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix nix flakes check #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

Fix nix flakes check #544

merged 1 commit into from
Jun 30, 2025

Conversation

JoseSK999
Copy link
Contributor
@JoseSK999 JoseSK999 commented Jun 29, 2025 •
edited
Loading

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other:

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other: flake.nix

Description

We need to use the latest nightly for clippy in flake.nix, such that it recognizes newer lints that we rely on.

In order to use the latest nightly, I updated the flake.lock rust-overlay via:

nix --experimental-features "nix-command flakes" flake update --update-input rust-overlay

Notes to the reviewers

This PR builds on top #541 (for cargo-fuzz install) and #543 (which adds the allow clippy::manual_is_multiple_of). These allows were required because the new lint suggests using a method that our MSRV doesn't have.

@JoseSK999 JoseSK999 force-pushed the fix-flakes branch 3 times, most recently from 128f214 to 909f0a8 Compare June 29, 2025 13:07
@jaoleal
Copy link
Contributor
jaoleal commented Jun 30, 2025

LGMT

jaoleal
jaoleal approved these changes Jun 30, 2025
View reviewed changes
@JoseSK999 JoseSK999 force-pushed the fix-flakes branch 3 times, most recently from df3b397 to fdfd39c Compare June 30, 2025 14:03
@Davidson-Souza Davidson-Souza added bug Something isn't working nix This change relates to the nix integration for floresta lint This issue or PR relates to code style and linting labels Jun 30, 2025
@JoseSK999 JoseSK999 force-pushed the fix-flakes branch 2 times, most recently from 3a65912 to d03380f Compare June 30, 2025 15:16
@JoseSK999
Fix nix flakes check
c46887b 
We need to use nightly for `clippy` in flake.nix, such that it recognizes newer lints that we rely on.

I run this:

```bash
nix --experimental-features "nix-command flakes" flake update --update-input rust-overlay
```
@JoseSK999 JoseSK999 mentioned this pull request Jun 30, 2025
Closed
18 tasks
@JoseSK999 JoseSK999 marked this pull request as ready for review June 30, 2025 16:20
@Davidson-Souza Davidson-Souza requested a review from jaoleal June 30, 2025 17:25
Davidson-Souza
Davidson-Souza approved these changes Jun 30, 2025
View reviewed changes
Copy link
Collaborator
@Davidson-Souza Davidson-Souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c46887b

@jaoleal
Copy link
Contributor
jaoleal commented Jun 30, 2025

ACK c46887b

@Davidson-Souza Davidson-Souza merged commit e0bde7d into vinteumorg:master Jun 30, 2025
10 checks passed
@JoseSK999 JoseSK999 deleted the fix-flakes branch June 30, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Davidson-Souza Davidson-Souza Davidson-Souza approved these changes

@jaoleal jaoleal Awaiting requested review from jaoleal

Assignees
No one assigned
Labels
bug Something isn't working lint This issue or PR relates to code style and linting nix This change relates to the nix integration for floresta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoseSK999 @jaoleal @Davidson-Souza
0