Benchmark FlatChainStore checksums #553
Open
+79
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a099fc to
0c84665
Compare
We have found that this method is slow because we read all the virtual data. It may be useful to benchmark it, which helps evaluating future changes. `DbCheckSum` and the method will now be public, although it seems harmless as the inner fields are private (i.e., the only way to produce a `DbCheckSum` is via the method).
0c84665 to
5150469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
We have found that this method is slow because we read all the virtual data. It may be useful to benchmark it, which helps evaluating future changes.
DbCheckSumand the method will now be public, although it seems harmless as the inner fields are private (i.e., the only way to produce aDbCheckSumis via the method).