8000 feat(react): Add missing react widget wrappers by ibgreen · Pull Request #9589 · visgl/deck.gl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(react): Add missing react widget wrappers #9589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

feat(react): Add missing react widget wrappers #9589

merged 2 commits into from
Apr 17, 2025

Conversation

ibgreen
Copy link
Collaborator
@ibgreen ibgreen commented Apr 17, 2025

Closes #

Background

  • Add React useWidget wrappers for the new widgets

Change List

@ibgreen ibgreen requested a review from chrisgervang April 17, 2025 15:43
@coveralls
Copy link
coveralls commented Apr 17, 2025 •
edited
Loading

Coverage Status

coverage: 91.489% (+0.001%) from 91.488%
when pulling 3c40641 on ib/react-widgets
into fa59506 on master.

chrisgervang
chrisgervang approved these changes Apr 17, 2025
View reviewed changes
Copy link
Collaborator
@chrisgervang chrisgervang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! My only feedback would be to carry the experimental export forward in the react module as well since we mean to say the API is unstable.

@ibgreen ibgreen mentioned this pull request Apr 17, 2025
Open
60 tasks
@ibgreen
Copy link
Collaborator Author
ibgreen commented Apr 17, 2025

Nice! My only feedback would be to carry the experimental export forward in the react module as well since we mean to say the API is unstable.

Ah yes, my invisible friend didn't catch that part...

@ibgreen ibgreen merged commit baa7f33 into master Apr 17, 2025
4 checks passed
@ibgreen ibgreen deleted the ib/react-widgets branch April 17, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgervang chrisgervang chrisgervang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibgreen @coveralls @chrisgervang
0