feat(widgets) Add StatsWidget #9623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgervang
approved these changes
May 8, 2025
modules/widgets/src/stylesheet.css
Outdated
Comment on lines
194
to
173
| mask-image: var( | ||
| --icon-camera, | ||
| url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 -960 960 960" fill="black"><path d="M480-320v-100q0-25 17.5-42.5T540-480h100v60H540v100h-60Zm60 240q-25 0-42.5-17.5T480-140v-100h60v100h100v60H540Zm280-240v-100H720v-60h100q25 0 42.5 17.5T880-420v100h-60ZM720-80v-60h100v-100h60v100q0 25-17.5 42.5T820-80H720Zm111-480h-83q-26-88-99-144t-169-56q-117 0-198.5 81.5T200-480q0 72 32.5 132t87.5 98v-110h80v240H160v-80h94q-62-50-98-122.5T120-480q0-75 28.5-140.5t77-114q48.5-48.5 114-77T480-840q129 0 226.5 79.5T831-560Z"/></svg>') | ||
| ); | ||
| -webkit-mask-image: var( | ||
| --icon-camera, | ||
| url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 -960 960 960" fill="black"><path d="M480-320v-100q0-25 17.5-42.5T540-480h100v60H540v100h-60Zm60 240q-25 0-42.5-17.5T480-140v-100h60v100h100v60H540Zm280-240v-100H720v-60h100q25 0 42.5 17.5T880-420v100h-60ZM720-80v-60h100v-100h60v100q0 25-17.5 42.5T820-80H720Zm111-480h-83q-26-88-99-144t-169-56q-117 0-198.5 81.5T200-480q0 72 32.5 132t87.5 98v-110h80v240H160v-80h94q-62-50-98-122.5T120-480q0-75 28.5-140.5t77-114q48.5-48.5 114-77T480-840q129 0 226.5 79.5T831-560Z"/></svg>') | ||
| ); | ||
| } | ||
|
|
||
| mask-image: var(--icon-camera, | ||
| url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 -960 960 960" fill="black"><path d="M480-320v-100q0-25 17.5-42.5T540-480h100v60H540v100h-60Zm60 240q-25 0-42.5-17.5T480-140v-100h60v100h100v60H540Zm280-240v-100H720v-60h100q25 0 42.5 17.5T880-420v100h-60ZM720-80v-60h100v-100h60v100q0 25-17.5 42.5T820-80H720Zm111-480h-83q-26-88-99-144t-169-56q-117 0-198.5 81.5T200-480q0 72 32.5 132t87.5 98v-110h80v240H160v-80h94q-62-50-98-122.5T120-480q0-75 28.5-140.5t77-114q48.5-48.5 114-77T480-840q129 0 226.5 79.5T831-560Z"/></svg>')); | ||
| -webkit-mask-image: var(--icon-camera, | ||
| url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 -960 960 960" fill="black"><path d="M480-320v-100q0-25 17.5-42.5T540-480h100v60H540v100h-60Zm60 240q-25 0-42.5-17.5T480-140v-100h60v100h100v60H540Zm280-240v-100H720v-60h100q25 0 42.5 17.5T880-420v100h-60ZM720-80v-60h100v-100h60v100q0 25-17.5 42.5T820-80H720Zm111-480h-83q-26-88-99-144t-169-56q-117 0-198.5 81.5T200-480q0 72 32.5 132t87.5 98v-110h80v240H160v-80h94q-62-50-98-122.5T120-480q0-75 28.5-140.5t77-114q48.5-48.5 114-77T480-840q129 0 226.5 79.5T831-560Z"/></svg>')); | ||
| } | ||
|
|
There was a problem hiding this comment.
The old format is clearer - what's the change from? If we're standardizing on a linter, we should discuss that separately from adding a new widget
There was a problem hiding this comment.
Yes, reverted... my new editor probably did this, and we don't seem to have CSS formatting in place.
Could be useful to add, now that we are starting to do serious work with stylesheets.
Comment on lines
+221
to
+232
| font-family: | ||
| 'SF Mono', | ||
| /* macOS */ | ||
| 'Menlo', | ||
| /* macOS */ | ||
| 'Consolas', | ||
| /* Windows */ | ||
| 'DejaVu Sans Mono', | ||
| /* Linux */ | ||
| 'Liberation Mono', | ||
| /* Linux */ | ||
| monospace; |
There was a problem hiding this comment.
I guess we could have these but it seems a little excessive to have multiple options per OS
There was a problem hiding this comment.
seems a little excessive to have multiple options per OS
- This seemed to be the recommended approach when I searched. I am not sure how the availability of these has evolved over time and browsers.
- My goal was to get a bit more interesting fonts without actually pulling in some big font blob in the CSS, and this is not a lot of styling compared to an import.
modules/widgets/src/stats-widget.tsx
Outdated
Comment on lines
69
to
75
| // if (props.formatters) { | ||
| // for (const name in props.formatters) { | ||
| // const f = props.formatters[name]; | ||
| // this._formatters[name] = | ||
| // typeof f === 'string' ? DEFAULT_FORMATTERS[f] || DEFAULT_COUNT_FORMATTER : f; | ||
| // } | ||
| // } |
|
So now we can show stats easily in the UI which should be very useful for optimization and debugging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Background
Change List