8000 added github templates for issues and pull-requests by mojoaxel · Pull Request #2787 · visjs/vis · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jul 29, 2019. It is now read-only.

added github templates for issues and pull-requests #2787

Merged
merged 1 commit into from
Feb 26, 2017
Merged

Conversation

mojoaxel
Copy link
Member

fixes #2418

@mojoaxel mojoaxel requested a review from Tooa February 25, 2017 20:51
yotamberk
yotamberk approved these changes Feb 25, 2017
View reviewed changes
Copy link
Member
@yotamberk yotamberk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mojoaxel mojoaxel force-pushed the github branch 2 times, most recently from c44f384 to ff57e7a Compare February 25, 2017 21:01
Tooa
Tooa suggested changes Feb 25, 2017
View reviewed changes
.github/PULL_REQUEST_TEMPLATE.md Outdated

Please make sure to check the following requirements before creating a pull request:
* [ ] All Pull-Requests must be against the [develop](https://github.com/almende/vis/tree/develop) branch. Pull-Request against `master` will be closed!
* [ ] Make sure your changes are basted on the latest version of the [develop](https://github.com/almende/vis/tree/develop) branch. (Use e.g. `git rebase origin develop` to update you feature-branch.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: are based

.github/PULL_REQUEST_TEMPLATE.md Outdated

Please make sure to check the following requirements before creating a pull request:
* [ ] All Pull-Requests must be against the [develop](https://github.com/almende/vis/tree/develop) branch. Pull-Request against `master` will be closed!
* [ ] Make sure your changes are basted on the latest version of the [develop](https://github.com/almende/vis/tree/develop) branch. (Use e.g. `git rebase origin develop` to update you feature-branch.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence should only consist of one dot at the end i.e. branch (use e.g. [ 10000 ...]).

This appears in several places.

.github/PULL_REQUEST_TEMPLATE.md Outdated
**Thank you for contributing to vis.js!!**

Please make sure to check the following requirements before creating a pull request:
* [ ] All Pull-Requests must be against the [develop](https://github.com/almende/vis/tree/develop) branch. Pull-Request against `master` will be closed!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change it to pull request in all places

.github/PULL_REQUEST_TEMPLATE.md Outdated

Please make sure to check the following requirements before creating a pull request:
* [ ] All Pull-Requests must be against the [develop](https://github.com/almende/vis/tree/develop) branch. Pull-Request against `master` will be closed!
* [ ] Make sure your changes are basted on the latest version of the [develop](https://github.com/almende/vis/tree/develop) branch. (Use e.g. `git rebase origin develop` to update you feature-branch.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feature branch

.github/PULL_REQUEST_TEMPLATE.md Outdated
Please make sure to check the following requirements before creating a pull request:
* [ ] All Pull-Requests must be against the [develop](https://github.com/almende/vis/tree/develop) branch. Pull-Request against `master` will be closed!
* [ ] Make sure your changes are basted on the latest version of the [develop](https://github.com/almende/vis/tree/develop) branch. (Use e.g. `git rebase origin develop` to update you feature-branch.)
* [ ] Provide an additional or updated examples to demonstrate your changes or new feature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example

.github/ISSUE_TEMPLATE.md Outdated

* Do you have a question on how to use vis.js? Please don't file an issue but ask your question e.g on [stackoverflow](https://stackoverflow.com/questions/tagged/vis.js) by using the tag 'vis.js' We will close use-specific questions!
* Have you already used the [github search](https://github.com/almende/vis/issues), read the [documentation](http://visjs.org/) and looked at the [examples](https://github.com/almende/vis/tree/develop/examples)?
* Make sure to mention with vis-component (network, timeline, graph2D, graph3d) you are referring to.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to add the relevant component (...) you are referring to.

.github/ISSUE_TEMPLATE.md Outdated
* Do you have a question on how to use vis.js? Please don't file an issue but ask your question e.g on [stackoverflow](https://stackoverflow.com/questions/tagged/vis.js) by using the tag 'vis.js' We will close use-specific questions!
* Have you already used the [github search](https://github.com/almende/vis/issues), read the [documentation](http://visjs.org/) and looked at the [examples](https://github.com/almende/vis/tree/develop/examples)?
* Make sure to mention with vis-component (network, timeline, graph2D, graph3d) you are referring to.
* Make sure to use the [latest version of vis.js](https://cdnjs.com/libraries/vis) for bug reports.
Copy link
Contributor
@Tooa Tooa Feb 25, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest version or should the use they develop branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puh, depends...latest version is ok here i think. maybe we have to ask some people to try the current branch.

.github/ISSUE_TEMPLATE.md Outdated
* Have you already used the [github search](https://github.com/almende/vis/issues), read the [documentation](http://visjs.org/) and looked at the [examples](https://github.com/almende/vis/tree/develop/examples)?
* Make sure to mention with vis-component (network, timeline, graph2D, graph3d) you are referring to.
* Make sure to use the [latest version of vis.js](https://cdnjs.com/libraries/vis) for bug reports.
* Make sure to mention with Browser and OS you are using when filing a bug.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with -> which

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browser

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filing -> creating

.github/ISSUE_TEMPLATE.md Outdated
* Make sure to mention with vis-component (network, timeline, graph2D, graph3d) you are referring to.
* Make sure to use the [latest version of vis.js](https://cdnjs.com/libraries/vis) for bug reports.
* Make sure to mention with Browser and OS you are using when filing a bug.
* Please provide a (minimal) code example that demonstrates your issue. We recommend using [jsbin](jsbin.com) for that.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provide a minimal [...]

.github/ISSUE_TEMPLATE.md Outdated
* Make sure to use the [latest version of vis.js](https://cdnjs.com/libraries/vis) for bug reports.
* Make sure to mention with Browser and OS you are using when filing a bug.
* Please provide a (minimal) code example that demonstrates your issue. We recommend using [jsbin](jsbin.com) for that.
* Delete this liste from the actual issue. (This is just for your information!)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See other comment.

@mojoaxel
Copy link
Member Author

@Tooa Thanks. Done!

bradh
bradh reviewed Feb 25, 2017
View reviewed changes
.github/ISSUE_TEMPLATE.md Outdated

Please make sure to **read the following list** before creating a new issue:

* This issue tracker is not supposed to be used for questions on how to use visjs. It is intended to be used for bug reports and feature requests! In case you face yourself with a usage question, then post your issue e.g. on [stackoverflow](https://stackoverflow.com/questions/tagged/vis.js) tagged with "vis.js".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some more direct language here:

* This issue tracker should not be used for questions on how to use visjs. It is intended to be used for bug reports and feature requests! If you have a usage question, then post your issue e.g. on [stackoverflow](https://stackoverflow.com/questions/tagged/vis.js) tagged with "vis.js".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not be too strict here! We get a lot of interesting question, we only want to get rid of the stupid ones. (Maybe we should write: "No stupid questions please", lol)

.github/PULL_REQUEST_TEMPLATE.md Outdated

* [ ] All pull requests must be to the [develop branch](https://github.com/almende/vis/tree/develop). Pull requests to the `master` branch will be closed!
* [ ] Make sure your changes are based on the latest version of the [develop branch](https://github.com/almende/vis/tree/develop). (Use e.g. `git fetch && git rebase origin develop` to update you feature branch).
* [ ] Provide an additional or updated an example to demonstrate your changes or new features.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated -> update

@yotamberk yotamberk merged commit dd55439 into develop Feb 26, 2017
@mojoaxel
Copy link
Member Author
mojoaxel commented Mar 1, 2017

I'm so waiting for this to go to live!!

@mojoaxel mojoaxel deleted the github branch March 1, 2017 12:43
marcortw pushed a commit to marcortw/vis that referenced this pull request Mar 12, 2017
@mojoaxel @marcortw
added github templates for issues and pull-requests (visjs#2787)
051c62e 
fixes visjs#2418
yotamberk pushed a commit that referenced this pull request May 2, 2017
@marcortw @yotamberk
Implementation of a week scale feature (#3009)
0a64249 
* Add Gitter badge (#2179)

* do not generate source-maps in distribution version

* add 'dist' folder for deployment

* added Badges

* added codeclimate badge

* added @Tooa to the support team

* added badges from isitmaintained.com (#2517)

* do not ignore dist and test folders in master

* generated dist files for v4.18.0

* generated dist files for v4.18.1

* Cheap fix for bug #2795

* Update to PR #2826 to use newline format

* changed to v4.18.1-SNAPSHOT

* chore(docs): general improvements (#2652)

* removed NOTICE file

* updated license date range to include 2017

* chore(docs): updated support team members

* chore: updated dependencies and devDependencies (#2649)

* Fixes instanceof Object statements for objects from other windows and iFrames. (#2631)

* Replaces instanceof Object checks with typeof to prevent cross tab issues.

* Adds missing space.

* chore: removed google-analytics from all examples (#2670)

* chore(docs): Add note that PRs should be submitted against the `develop` branch (#2623)

Related to: #2618
Related to: #2620

* feat(timeline): Change setCustomTimeTitle title parameter to be a string or a function (#2611)

* change setCustomTimeTitle title parameter, Now could be an string or a function
* Fixed indent and spacing

* feat(timeline): refactor tooltip to only use one dom-element (#2662)

* feat(network): Allow for image nodes to have a selected or broken image (#2601)

* feat(tests): run mocha tests in travis ci (#2687)

* Added showX(YZ)Axis options to Graph3d (#2686)

* Added showX(YZ)Axis to Graph3d

* Added show_Axis options to docs and playground example

* Resolved merge conflict

* Added show_Axis options to docs and playground example

* fix(build): use babel version compatible with webpack@1.14 (#2693)

fixes #2685

* feat(docs): use babel preset2015 for custom builds (#2678)

* add link to a mentioned example (#2709)

* chore(lint): added support for eslint (#2695)

* Trivial typo fix in how_to_help doc. (#2714)

* fix(timeline): #2598 Flickering onUpdateTimeTooltip (#2702)

* Fix redraw order
* Fix error when option is not defined
* Allow template labels
* Add .travis.yml file
* Add experiment travis code
* Fix react example
* Add animation to onUpdateTooltip

* fix(timeline): #778 Tooltip does not work with background items in timeline (#2703)

* Fix redraw order
* Fix error when option is not defined
* Allow template labels
* Add .travis.yml file
* Add experiment travis code
* Fix react example
* Make items z-index default to 1

* Add initial tests for Timeline PointItem (#2716)

* fix(timeline): #2679 TypeError: Cannot read property 'hasOwnProperty' of null (#2735)

* Fix redraw order
* Fix error when option is not defined
* Allow template labels
* Add .travis.yml file
* Add experiment travis code
* Fix react example
* Fix bug in item editable

* feat(timeline): #2647 Dynamic rolling mode option (#2705)

* Fix redraw order
* Fix error when option is not defined
* Allow template labels
* Add .travis.yml file
* Add experiment travis code
* Fix react example
* Add toggleRollingMode option
* Update docs with toggleRollingMode option

* fixes timestep next issue (#2732)

* feat(timeline): added new locales for french and espanol (#2723)

* Fix eslint problem on Travis. (#2744)

* fix: Range.js "event" is undeclared (#2749)

* fix(timeline): #2720 Problems with option editable (#2743)

Clean up and centralise edit status for Timeline Items.

* feat(network): Improve the performance of the network layout engine (#2729)

* Improve the performance of the network layout engine

Short-cut the execution of a number of methods in LayoutEngine to make them
handle highly-connected graphs better.

* Demonstrations of layouts of large networks

* Added support to supply an end to bar charts to have them scale (#2760)

* Added support to supply an X2 to bar charts to have them scale

* Fixed graph2d stacking issue.  It no longer takes into account hidden items

* Changed x2 to end per recommendation and added this to the docs

* Initial tests for timeline ItemSet. (#2750)

Somewhat more complicated setup, associated with the need for a real window.

* [Timeline] Modify redraw logic to treat scroll as needing restack. (#2774)

This addresses #1982 and #1417.

It possibly reduces performance, but correctness seems better.

* fix(timeline): #2672 Item events original event (#2704)

* Fix redraw order

* Fix error when option is not defined

* Allow template labels

* Add .travis.yml file

* Add experiment travis code

* Fix react example

* Fix events returned from mouse events

* Fix example

* Rename censor to stringifyObject in example

* [timeline] Update examples to use ISOString format. (#2791)

Resolves #2790

* [timeline] Update serialization example to use ISOString dates. (#2789)

Resolves #2696

* added github templates for issues and pull-requests (#2787)

fixes #2418

* feat(timeline): Add item data as argument to the template function (#2799)

* Fix regression introduced in #2743. (#2796)

* Fix for issue #2536 (#2803)

* Fix for issue #2536

* Adjusted documentation for fix.

* Adjustments due to review

* Grrrrr whitespace

* Fixed Travis issue

* Cheap fix for bug #2795

* Update to PR #2826 to use newline format

* Update to gitignore to reflect changes on remote

* clean dist folder

* Local gitignore update

* Just a first example file for the week scale feature

* Allowing sourcemap creation

* Initial (non-functional) commit to ensure we insert code at the right places (check TODOs)

* Functional, not bug-free version which works with locale aware week numbers.

* Locale-aware implementation and simplified major labels to a full year

* Trying to make the major labels show the correct start date

* Working implementation of week numbers using localization.

* removing development leftovers

* Updated package.json

* Reintagrate package.json from accidental deletion

* Updates for package.json

* Fixing package.json

* Integrate the week numbers feature in the documentation.

* Reverting local changes to .gitignore

* Reverting local changes

* Extending examples to cover the case when 1st day of week and 1st day of month align; Fixing display bug so that week numbers are not repeated in minorLabels

* Putting the examples into a loop
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradh bradh bradh left review comments

@yotamberk yotamberk yotamberk approved these changes

@Tooa Tooa Tooa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mojoaxel @bradh @yotamberk @Tooa
0