8000 Log when we fail to accept a conn by spark4 · Pull Request #5881 · vitessio/vitess · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Log when we fail to accept a conn #5881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2020
Merged

Log when we fail to accept a conn #5881

merged 1 commit into from
Mar 3, 2020

Conversation

spark4
Copy link
Contributor
@spark4 spark4 commented Mar 2, 2020 •
edited
Loading

Overview

This PR introduces a new counter that will track failures when attempting to accept connections to enable greater visibility into these error states.

Testing

Test cases were added to existing unit tests to ensure that we were incrementing the new connClose counter as intended.

@spark4 spark4 requested a review from sougou as a code owner March 2, 2020 22:11
rafael
rafael reviewed Mar 2, 2020
View reviewed changes
@spark4 spark4 force-pushed the sp-log-conn-accept-err branch from 5f50d1e to 594990a Compare March 2, 2020 23:30
deepthi
deepthi reviewed Mar 2, 2020
View reviewed changes
@spark4 spark4 force-pushed the sp-log-conn-accept-err branch from 594990a to 3eb5c3b Compare March 2, 2020 23:36
@spark4
Log when we fail to accept a conn
de0e7c4 
Signed-off-by: Serry Park <me@serry.co>
@spark4 spark4 force-pushed the sp-log-conn-accept-err branch from 3eb5c3b to de0e7c4 Compare March 2, 2020 23:38
@rafael
Copy link
Member
rafael commented Mar 2, 2020

Awesome! LGTM. Will merge when CI/CD finishes.

rafael
rafael approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member
@rafael rafael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafael rafael merged commit f0797e7 into vitessio:master Mar 3, 2020
@rafael rafael deleted the sp-log-conn-accept-err branch March 3, 2020 00:30
ajm188 pushed a commit to tinyspeck/vitess that referenced this pull request Mar 11, 2020
@rafael @ajm188
Merge pull request vitessio#5881 from tinyspeck/sp-log-conn-accept-err
a9e46a5 
Log when we fail to accept a conn
@ajm188 ajm188 mentioned this pull request Mar 11, 2020
Merged
@ajm188 ajm188 mentioned this pull request Jun 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi left review comments

@rafael rafael rafael approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spark4 @rafael @deepthi
0