8000 Modify how the restore workflow using the resource name by blackpiglet · Pull Request #8797 · vmware-tanzu/velero · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Modify how the restore workflow using the resource name #8797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

Modify how the restore workflow using the resource name #8797

merged 1 commit into from
Mar 21, 2025
+64 −68

Conversation

blackpiglet
Copy link
Contributor
@blackpiglet blackpiglet commented Mar 18, 2025 •
edited
Loading

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@blackpiglet blackpiglet changed the title Update the restore resource name for VS and VSC, because their names Update the restore resource name for VS and VSC, because their names are updated in RIA. Mar 18, 2025
@codecov Codecov
Copy link
codecov bot commented Mar 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.14286% with 27 lines in your changes missing coverage. Please review.

Project coverage is 59.55%. Comparing base (0d27d52) to head (1652e6b).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/restore/restore.go 57.14% 27 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8797      +/-   ##
==========================================
- Coverage   59.58%   59.55%   -0.03%     
==========================================
  Files         370      370              
  Lines       40233    40229       -4     
==========================================
- Hits        23971    23959      -12     
- Misses      14764    14771       +7     
- Partials     1498     1499       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blackpiglet blackpiglet marked this pull request as ready for review March 18, 2025 07:09
ywk253100
ywk253100 previously approved these changes Mar 18, 2025
View reviewed changes
Lyndon-Li
Lyndon-Li reviewed Mar 18, 2025
View reviewed changes
@blackpiglet blackpiglet force-pushed the update_vs_vsc_name branch 3 times, most recently from 034683e to b2e773d Compare March 18, 2025 09:50
@blackpiglet blackpiglet changed the title Update the restore resource name for VS and VSC, because their names are updated in RIA. Modify the restore workflow's resource name usage Mar 18, 2025
@blackpiglet blackpiglet changed the title Modify the restore workflow's resource name usage Modify how the restore workflow using the resource name Mar 18, 2025
@blackpiglet blackpiglet force-pushed the update_vs_vsc_name branch 2 times, most recently from e298600 to 3ed2b62 Compare March 18, 2025 11:33
kaovilai
kaovilai reviewed Mar 18, 2025
View reviewed changes
kaovilai
kaovilai previously approved these changes Mar 18, 2025
View reviewed changes
@blackpiglet blackpiglet requested a review from reasonerjt March 19, 2025 02:26
@blackpiglet
Copy link
Contributor Author

@reasonerjt PTAL.

kaovilai
kaovilai previously approved these changes Mar 19, 2025
View reviewed changes
Lyndon-Li
Lyndon-Li reviewed Mar 20, 2025
View reviewed changes
@blackpiglet
Modify how the restore workflow using the resource name.
1652e6b 
The restore workflow used name represents the backup resource and the
restore to be restored, but the restored resource name may be different
from the backup one, e.g. PV and VSC are global resources, to avoid
conflict, need to rename them.
Reanme the name variable to backupResourceName, and use obj.GetName()
for restore operation.

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
@Lyndon-Li Lyndon-Li merged commit d086cb2 into vmware-tanzu:main Mar 21, 2025
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaovilai kaovilai kaovilai approved these changes

@Lyndon-Li Lyndon-Li Lyndon-Li approved these changes

@ywk253100 ywk253100 ywk253100 left review comments

@shubham-pampattiwar shubham-pampattiwar Awaiting requested review from shubham-pampattiwar

@sseago sseago Awaiting requested review from sseago

@reasonerjt reasonerjt Awaiting requested review from reasonerjt

Assignees

@blackpiglet blackpiglet

Labels
has-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blackpiglet @ywk253100 @kaovilai @Lyndon-Li
0