Fix errors when tag a build #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git for-each-ref returns wrong tag name, use git describe to get latest tag. Remove branch and event conditions since branch is empty if it is a tag event. Execute vic-ui and bundle when status is success.
5608276 to
460e65a
Compare
renmaosheng
approved these changes
Sep 5, 2018
DanielXiao
added a commit
to DanielXiao/vic-ui
that referenced
this pull request
Sep 5, 2018
Git for-each-ref returns wrong tag name, use git describe to get latest tag. Remove branch and event conditions since branch is empty if it is a tag event. Execute vic-ui and bundle when status is success. (cherry picked from commit 586ed3f)
renmaosheng
pushed a commit
that referenced
this pull request
Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git for-each-ref returns wrong tag name, use git describe to
get latest tag.
Remove branch and event conditions since branch is empty if
it is a tag event. Execute vic-ui and bundle when status is
success.
Fixes #
PR acceptance checklist:
[ ] All unit tests pass
[ ] All e2e tests pass
[ ] Unit test(s) included*
[ ] e2e test(s) included*
[ ] Screenshot attached and UX approved*
*if applicable, add n/a if not