add timeout cache for getVicVms #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjun
reviewed
Jun 11, 2019
wjun
reviewed
Jun 11, 2019
h5c/vic-service/src/main/java/com/vmware/vic/cache/LocalCache.java
Outdated
Show resolved
Hide resolved
wjun
reviewed
Jun 11, 2019
h5c/vic-service/src/main/java/com/vmware/vic/cache/LocalCache.java
Outdated
Show resolved
Hide resolved
wjun
reviewed
Jun 11, 2019
h5c/vic-service/src/main/java/com/vmware/vic/cache/LocalCache.java
Outdated
Show resolved
Hide resolved
wjun
reviewed
Jun 11, 2019
h5c/vic-service/src/main/java/com/vmware/vic/cache/LocalCache.java
Outdated
Show resolved
Hide resolved
269f077 to
cbffbee
Compare
wjun
reviewed
Jun 12, 2019
| private long timeout; | ||
|
|
||
| private ValueObject(Object value, long timeout) { | ||
| super(); |
There was a problem hiding this comment.
This line looks not necessary. Please remove it.
Signed-off-by: Meina Zhou <meinaz@vmware.com>
cbffbee to
a4b9961
Compare
wjun
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be serious performance problem when have large scale of vms. That because the propFetcher will invoke getVicVms for more than 10 times. This method will be very slow if large scale of vms.
This pr is focus on introduce a memory cache and set the timeout to no more than 1 min to avoid interact with vc vim 25 interface.