feat(icon): add tsdoc icon to tsdoc.json #3569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Gajdascz, thank you for your contribution. Unfortunately, the icon needs some rework before accepting this PR. As you can see below, comparing both the original and the proposed one, it's clear that the icons are very different.
|
|
Hello @robertohuertasm, Thank you for the feedback. I've adjusted the icon to (hopefully) match the proposal and standards. If anything is off or requires more work please let me know and I will gladly adjust accordingly. |
Merge remote changes with local feature branch.
Icons Background Testfile_type_tsdoc (808 bytes) |
robertohuertasm
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to the tsdoc.json file.
Fixes #3566
Changes proposed: