8000 fix(docusaurus): correct extensionsGlob to not include prefix dot by AviVahl · Pull Request #3668 · vscode-icons/vscode-icons · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(docusaurus): correct extensionsGlob to not include prefix dot #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

AviVahl
Copy link
Contributor
@AviVahl AviVahl commented Jan 7, 2025

with the prefix dot included, vsicons-icon-theme.json has docusaurus.config..ts as a generated value.

Fixes #IssueNumber

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

@robertohuertasm robertohuertasm added this to the Next milestone Jan 8, 2025
Copy link
Member
@robertohuertasm robertohuertasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! ❤️

@robertohuertasm
Copy link
Member

It seems there's some formatting issue.

@remcohaszing
Copy link
Member

The formatting issue was caused by #3665, and is resolved by #3666. I suggest to merge that, then rebase.

@AviVahl
Copy link
Contributor Author
AviVahl commented Jan 11, 2025

I can rebase once that other PR merges. (or a maintainer can, as they have access to this branch)

EDIT: rebased to current master (which still has the formatting issue)

EDIT 2: rebased once again

with the prefix dot included, `vsicons-icon-theme.json` has `docusaurus.config..ts` as a generated value.
@remcohaszing remcohaszing merged commit 62097b7 into vscode-icons:master Jan 29, 2025
1 check passed
@AviVahl AviVahl deleted the patch-1 branch January 30, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0