chore: refactor linting setup #3681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prettier now checks all supported files in the project instead of a glob. Prettier respects `.gitignore`, so `p 8000 ackage*.json` was removed from `.prettierignore`. ESLint now uses configuration overrides to specify additional file extensions instead of a CLI flag. Linting no longer happens before building, so we can run tests and debug, even if there are linting errors. The GitHub actions test workflow now specifies eslint and prettier jobs. These jobs are run once, instead of for every combination in our test matrix. This means linting issues will only show up once in pull requests instead of for every failed build job.
c703a6c to
d8df9c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prettier now checks all supported files in the project instead of a glob.
Prettier respects
.gitignore, sopackage*.jsonwas removed from.prettierignore.ESLint now uses configuration overrides to specify additional file extensions instead of a CLI flag.
Linting no longer happens before building, so we can run tests and debug, even if there are linting errors.
The GitHub actions test workflow now specifies eslint and prettier jobs. These jobs are run once, instead of for every combination in our test matrix. This means linting issues will only show up once in pull requests instead of for every failed build job.