feat(icon): add Dune and OPAM file type icons (OCaml build system files) #3722
Conversation
Icons Background Testfile_type_dune (603 bytes)file_type_opam (4710 bytes) |
|
Hi @web-dev-sam! Thanks for your contribution. It would be nice to try to optimize the opam icon. We're aiming for 2KB, if possible. |
Got Dune from 1.9K to 0.6K and Opam from 9K to 4.5K. Removed some uneeded svg path nodes and elements however I'm not seeing Opam going down to 2K. That would need reshaping to the design/caml and I'm not a designer so wouldn't feel capable of doing that. Also, both icons are now SVGO optimized. Edit: Also just checked the OCaml icon which is basically a subset of the Opam icon and that one is a bit bigger at 5K+ so I see it as a win. Edit: Edit: I tried auto optimizing (svgo) all icons which also saved quiet a bit overall. Would it make sense to create a new PR to change/optimize all icons? Tried it and seems to work fine. Here is AI summary of results: The optimization process achieved nearly 13% reduction in file size on average, saving about 487 KiB across all files. The total size was reduced from approximately 4,244 KiB to 3,757 KiB. |
|
@web-dev-sam thanks for fixing the issue. I've updated the icons:
|
|
Regarding your comment of applying svgo to all the files, I think it could be useful. The extension would be lighter. |
|
@web-dev-sam, on second thought, I'm not sure about having that massive PR passing SVGO to the whole icons folder. I'm thinking that we may miss some optimizations that alter the visual aspect of the icon in a notable way. That would require a massive review (around 1370 icons and growing). I guess we could do such a thing in an incremental way to make the review easier (groups of 10, 20?). In any case, I think it may make sense to ask for users to try to apply it as an optimization step if possible. |
Changes proposed:
Adding OCaml package manager and build file icons. Dune and Opam.