-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tighten up Required Context Role: group #1359
Conversation
- only if group is contained in primary context role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this helps clarify. thank you
@mcking65 This PR also touches the menuitem roles. After both PRs go in, we can look at whether the menuitem prose needs to be updated to match the new prose in listbox and tree. I'll open an issue as a reminder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are adding this new concept we should be complete. I think we are missing changes to required context role on
row (table -> rowgroup , grid -> rowgroup, treegrid -> rowgroup)
Good catch, @jnurthen ! |
This is ready for final review. The latest commit reorders group/rowgroup items that are required context roles for option, treeitem, and menuitem roles so that the group comes first, followed by left arrow, followed by the contained item role, as suggested by @jnurthen in today's call. This uses a left-pointing arrow character in an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thank you!
The group role can only be a required context role if the group is contained in the primary context role.
So:
option
can only be in a group if the group is in alistbox
treeitem
can only be in a group if the group is in atree
menuitem[checkbox|radio]
can only be in a group if the group is in amenu
ormenubar
Preview (#option) (#treeitem) (#menuitem) | Diff