Add warning about comparing DID URLs containing query parameters. #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlongley
reviewed
Jun 2, 2025
Comment on lines
+1201
to
+1205
| Implementers are urged to avoid using [=DID URLs=] that contain more than a | ||
| single query parameter when comparing [=DID URLs=] for equivalence. There are | ||
| no normalization rules defined for query parameters in this specification and | ||
| any query parameter normalization rules defined at the DID Method specification | ||
| or application layer are not universally recognized rules. |
There was a problem hiding this comment.
I could see another specification handling this for some ecosystem/use case in the future, so I have a slight suggestion. I also had some trouble following what the advice was here, so let me know if the additional rewording helps:
Suggested change
| Implementers are urged to avoid using [=DID URLs=] that contain more than a | |
| single query parameter when comparing [=DID URLs=] for equivalence. There are | |
| no normalization rules defined for query parameters in this specification and | |
| any query parameter normalization rules defined at the DID Method specification | |
| or application layer are not universally recognized rules. | |
| Implementers are urged to avoid comparing [=DID URLs=] with more than | |
| one query parameter for equivalence without a specification specifically | |
| designed for that purpose. There are no normalization rules defined for | |
| query parameters in this specification and any query parameter normalization | |
| rules defined at the DID Method specification or application layer are not | |
| universally recognized rules. |
There was a problem hiding this comment.
A light tweak to @dlongley's suggestion...
Suggested change
| Implementers are urged to avoid using [=DID URLs=] that contain more than a | |
| single query parameter when comparing [=DID URLs=] for equivalence. There are | |
| no normalization rules defined for query parameters in this specification and | |
| any query parameter normalization rules defined at the DID Method specification | |
| or application layer are not universally recognized rules. | |
| Implementers are urged to avoid comparing [=DID URLs=] for equivalence when | |
| they have more than one query parameter without a specification specifically | |
| designed for that purpose. This specification defines no normalization rules | |
| for query parameters, and any query parameter normalization rules defined at | |
| the DID Method specification or application layer are not universally | |
| recognized rules. |
|
This was discussed during the #did meeting on 19 June 2025. View the transcriptAdd warning about comparing DID URLs containing query parameters. #895<ottomorac> w3c/did#895 ottomorac: This attempts to clarify that the DID core spec defines no normalization rules for query parameters and warning when comparing DID URLs. |
ottomorac
approved these changes
Jun 19, 2025
TallTed
suggested changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address issue #865 by adding a warning about comparing DID URLs that contain more than a single query parameter.
Preview | Diff