8000 Github widget crashes on refresh when there's no network connection · Issue #75 · wtfutil/wtf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Github widget crashes on refresh when there's no network connection #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matrinox opened this issue May 30, 2018 · 3 comments
Closed

Github widget crashes on refresh when there's no network connection #75

matrinox opened this issue May 30, 2018 · 3 comments
Assignees
@senorprogrammer
Labels
🐛 bug "Houston, we've had a problem." 👍 confirmed

Comments

@matrinox
Copy link
Contributor
matrinox commented May 30, 2018 •
edited
Loading

Problem

I have only used the Github widget and I find it crashes when you have no internet and it either automatically refreshes or you manually refresh it. This can also happen when you put your computer on standby.

Steps to Reproduce

  • Configure wtf with Github widget
  • Disable wifi and other internet sources
  • Press ctrl+R

Expected result: user-friendly error message without crashing
Actual result: crashes

Screenshots

Attached is a screenshot of this happening:
screen shot 2018-05-30 at 11 19 20 am
@senorprogrammer senorprogrammer added 🐛 bug "Houston, we've had a problem." high labels May 30, 2018
@senorprogrammer senorprogrammer changed the title BUG: Crashes when restarting with no internet access Github widget crashes on refresh when there's no network connection May 30, 2018
@senorprogrammer
Copy link
Collaborator 
github.com/senorprogrammer/wtf/github/github_repo.go:40
github.com/senorprogrammer/wtf/github.(*Widget).displayStats(0xc42017a360, 0xc420089130, 0x5b, 0x15bfdc8)
github.com/senorprogrammer/wtf/github/display.go:67 +0x44
github.com/senorprogrammer/wtf/github.(*Widget).display(0xc42017a360)
github.com/senorprogrammer/wtf/github/display.go:22 +0x2a6
github.com/senorprogrammer/wtf/github.(*Widget).Refresh(0xc42017a360)
github.com/senorprogrammer/wtf/github/widget.go:63

@matrinox
Copy link
Contributor Author

Forgot to mention, I only filed a bug for Github cause that's what I'm testing but perhaps we should check other widgets using internet like JIRA?

@senorprogrammer
Copy link
Collaborator

Yep, very much so. The expected behaviour is to show the raised error in the widget textview. This is easy enough to test by disabling the Github widget and trying again.

@senorprogrammer senorprogrammer self-assigned this May 30, 2018
senorprogrammer added a commit that referenced this issue May 31, 2018
@senorprogrammer
Close #75. Github no longer crashes on network failure
86d43e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@senorprogrammer senorprogrammer

Labels
🐛 bug "Houston, we've had a problem." 👍 confirmed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@senorprogrammer @matrinox
0