Script functions #92
Merged
Script functions #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements new Groovy completions for script functions and refactors some existing suggestion handling logic while addressing issues with formatting returned snippet data.
- Introduces core completions for Groovy script functions (println, print, printf) in a new file.
- Refactors the AEM code completions to use SuggestionKind constants instead of string literals.
- Improves snippet content and documentation by trimming extraneous whitespace.
Reviewed Changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ui.frontend/src/utils/monaco/groovy/completions/core.ts | Added core Groovy completions for script functions. |
| ui.frontend/src/utils/monaco/groovy/completions/aem-code.ts | Updated completion item kinds to rely on SuggestionKind constants. |
| ui.frontend/src/utils/monaco/groovy/completions.ts | Registered the new core completions in the overall completions registration. |
| core/src/main/java/com/vml/es/aem/acm/core/snippet/Snippet.java | Modified snippet getters to return trimmed values to enhance output formatting. |
Files not reviewed (4)
- ui.content.example/src/main/content/jcr_root/conf/acm/settings/script/manual/example/ACM-1_classes_jms.groovy: Language not supported
- ui.content.example/src/main/content/jcr_root/conf/acm/settings/script/manual/example/ACM-1_classes_rtjar.groovy: Language not supported
- ui.content.example/src/main/content/jcr_root/conf/acm/settings/script/manual/example/ACME-200_hello-world.groovy: Language not supported
- ui.content.example/src/main/content/jcr_root/conf/acm/settings/script/manual/example/ACME-201_arguments.groovy: Language not supported
Comments suppressed due to low confidence (1)
ui.frontend/src/utils/monaco/groovy/completions/aem-code.ts:96
- [nitpick] Confirm that the SuggestionKind constants are correctly imported and used consistently across the completion providers for clarity and maintainability.
case SuggestionKind.CLASS:
| @@ -45,11 +45,11 @@ public String getId() { | |||
| } | |||
|
|
|||
| public String getContent() throws AcmException { | |||
| return definition.getContent(); | |||
| return StringUtils.trim(definition.getContent()); | |||
There was a problem hiding this comment.
If definition.getContent() could return null, consider using a null-safe approach such as StringUtils.trimToEmpty to avoid potential NullPointerExceptions.
Suggested change
| return StringUtils.trim(definition.getContent()); | |
| return StringUtils.trimToEmpty(definition.getContent()); |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #79, #90