Value map decorator extended #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR extends the value map decorator functionality to support additional date/time conversions by introducing new methods in DateUtils and a new ValueMapDecoratorExtended class. Key changes include:
- Adding several conversion methods in DateUtils to handle LocalDateTime, LocalDate, Date, and Calendar transformations.
- Introducing ValueMapDecoratorExtended to encapsulate extended conversion logic.
- Updating RepoResourceState, Arguments, and Condition to utilize ValueMapDecoratorExtended and the revised DateUtils methods.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| core/src/main/java/com/vml/es/aem/acm/core/util/DateUtils.java | Added new conversion methods and renamed localDateTimeFromString to zonedDateTimeFromString for clarity. |
| core/src/main/java/com/vml/es/aem/acm/core/repo/RepoResourceState.java | Replaced ValueMapDecorator with ValueMapDecoratorExtended to support extended date/time conversions. |
| core/src/main/java/com/vml/es/aem/acm/core/code/ValueMapDecoratorExtended.java | Introduced a new class extending ValueMapDecorator with additional conversion logic for date/time values. |
| core/src/main/java/com/vml/es/aem/acm/core/code/Condition.java | Updated method call to reflect the new zonedDateTimeFromString method in DateUtils. |
| core/src/main/java/com/vml/es/aem/acm/core/code/Arguments.java | Replaced ValueMapDecorator with ValueMapDecoratorExtended in the getValues() method. |
Comments suppressed due to low confidence (1)
core/src/main/java/com/vml/es/aem/acm/core/util/DateUtils.java:79
- Ensure that the exception class DateTimeParseException is imported (i.e., add "import java.time.format.DateTimeParseException;") to avoid compilation issues.
} catch (DateTimeParseException ignored) {
core/src/main/java/com/vml/es/aem/acm/core/code/ValueMapDecoratorExtended.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.