File argument #125
Merged
File argument #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces and integrates file upload functionality into the application by adding a new FileUploader component, updating argument types to support file and multi‐file inputs, and implementing backend file management endpoints.
- Adds a FileUploader component in the frontend to handle file uploads and deletions.
- Updates CodeArgumentInput to render file and multi‐file inputs using the new FileUploader component.
- Introduces new backend components (FileServlet, FileManager, and related classes) to support file operations.
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ui.frontend/src/components/UserInfo.tsx | Removed an extra blank line for style consistency. |
| ui.frontend/src/components/FileUploader.tsx | New FileUploader component for file handling using React Spectrum components. |
| ui.frontend/src/components/CodeArgumentInput.tsx | Updated to conditionally render FileUploader for file and multi‐file arguments. |
| ui.content/.../argument/*.yml | Updated snippets and documentation to reflect file and multi‐file usage. |
| core/src/main/java/dev/vml/es/acm/core/util/TypeUtils.java | Added conversion support for File and array types. |
| core/src/main/java/dev/vml/es/acm/core/servlet/FileServlet.java | New servlet to manage file upload and deletion endpoints. |
| core/src/main/java/dev/vml/es/acm/core/code/* | New/updated classes to support file and multi‐file arguments and management. |
Comments suppressed due to low confidence (1)
core/src/main/java/dev/vml/es/acm/core/code/FileManager.java:25
- [nitpick] The exception message in this validation could be improved for clarity, for example by adding a space after 'root directory' in the error text.
if (!StringUtils.startsWith(path, root().getAbsolutePath())) {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.