8000 [DOCS-1422][DOCS-1375] Document workspace templates by mdlinville · Pull Request #1325 · wandb/docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[DOCS-1422][DOCS-1375] Document workspace templates #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
May 28, 2025
Merged

[DOCS-1422][DOCS-1375] Document workspace templates #1325

merged 20 commits into from
May 28, 2025

Conversation

mdlinville
Copy link
Contributor
@mdlinville mdlinville commented May 14, 2025 •
edited
Loading

DOCS-1422 Document workspace templates
DOCS-1375 Add private preview admonition

Ready for peer review, can be merged ahead of 0.69 release notes on 5/27, so I have removed the DO NOT MERGE.

Preview: https://docs-1422.docodile.pages.dev/guides/track/workspaces/#workspace-templates

@mdlinville mdlinville requested a review from ktmathews89 May 14, 2025 21:21
@mdlinville mdlinville requested a review from a team as a code owner May 14, 2025 21:21
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link
cloudflare-workers-and-pages bot commented May 14, 2025 •
edited
Loading

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: b71a5b1
Status: ✅  Deploy successful!
Preview URL: https://0cf0f1ee.docodile.pages.dev
Branch Preview URL: https://docs-1422.docodile.pages.dev

View logs

mdlinville
mdlinville commented May 14, 2025
View reviewed changes
@ktmathews89
Copy link

I actually think it might be better to have @tristan-spaulding2 opinion on this docs update....

ktmathews89
ktmathews89 reviewed May 16, 2025
View reviewed changes
ktmathews89
ktmathews89 reviewed May 16, 2025
View reviewed changes
@mdlinville mdlinville requested a review from ktmathews89 May 19, 2025 23:09
ktmathews89
ktmathews89 approved these changes May 20, 2025
View reviewed changes
Copy link
@ktmathews89 ktmathews89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look great!

@mdlinville mdlinville requested a review from ngrayluna May 20, 2025 22:55
tristan-spaulding2
tristan-spaulding2 requested changes May 21, 2025
View reviewed changes
@mdlinville mdlinville changed the title [DOCS-1422] Document workspace templates [DOCS-1422][DOCS-1375] Document workspace templates May 21, 2025
ngrayluna
ngrayluna requested changes May 21, 2025
View reviewed changes
Copy link
Contributor
@ngrayluna ngrayluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

mdlinville added 3 commits May 21, 2025 15:15
@mdlinville
Merge remote-tracking branch 'origin/main' into DOCS-1422
79634b1
@mdlinville
Merge remote-tracking branch 'origin/DOCS-1422' into DOCS-1422
7c8e59f
@mdlinville
Add more specific private preview include
2037cb6 
- Enterprise license is required for the whole feature
- Dedicated and Self-Hosted: Private preview, enrollment required
tristan-spaulding2
tristan-spaulding2 approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor
@tristan-spaulding2 tristan-spaulding2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

mdlinville
mdlinville commented May 22, 2025
View reviewed changes
mdlinville
mdlinville commented May 22, 2025
View reviewed changes
@mdlinville mdlinville requested a review from ngrayluna May 22, 2025 21:41
@mdlinville mdlinville added the DO-NOT-MERGE For PRs that should not be merged yet label May 22, 2025
@mdlinville mdlinville mentioned this pull request May 22, 2025
Merged
@mdlinville mdlinville removed the DO-NOT-MERGE For PRs that should not be merged yet label May 23, 2025
ngrayluna
ngrayluna reviewed May 27, 2025
View reviewed changes
Copy link
Contributor
@ngrayluna ngrayluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick comments

mdlinville
mdlinville commented May 27, 2025
View reviewed changes
mdlinville
mdlinville commented May 27, 2025
View reviewed changes
@mdlinville @ngrayluna
Noah's feedback
090fdad 
Co-authored-by: Noah Luna <15202580+ngrayluna@users.noreply.github.com>
@mdlinville mdlinville requested a review from ngrayluna May 27, 2025 22:01
@mdlinville mdlinville enabled auto-merge (squash) May 28, 2025 16:46
@mdlinville mdlinville merged commit 75e50d4 into main May 28, 2025
4 checks passed
@mdlinville mdlinville deleted the DOCS-1422 branch May 28, 2025 17:32
mdlinville added a commit that referenced this pull request May 28, 2025
@mdlinville
Revert "[DOCS-1422][DOCS-1375] Document workspace templates (#1325)"
9b99d04 
This reverts commit 75e50d4.
@mdlinville mdlinville mentioned this pull request May 28, 2025
Merged
mdlinville added a commit that referenced this pull request May 28, 2025
@mdlinville
Revert "[DOCS-1422][DOCS-1375] Document workspace templates" (#1352)
0b52d1c 
Reverts #1325

Broken Prod deploy
@mdlinville mdlinville mentioned this pull request Jun 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktmathews89 ktmathews89 ktmathews89 approved these changes

@ngrayluna ngrayluna ngrayluna approved these changes

@tristan-spaulding2 tristan-spaulding2 tristan-spaulding2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdlinville @ktmathews89 @ngrayluna @tristan-spaulding2
0