8000 [DOCS-1630] Fix BYOB details after recent rewrite by mdlinville · Pull Request #1433 · wandb/docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[DOCS-1630] Fix BYOB details after recent rewrite #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 3, 2025
Merged

[DOCS-1630] Fix BYOB details after recent rewrite #1433

merged 6 commits into from
Jul 3, 2025

Conversation

mdlinville
Copy link
Contributor
@mdlinville mdlinville commented Jul 2, 2025 •
edited
Loading

DOCS-1630 Fix BYOB details after recent rewrite

  • Dedicated Cloud and Self-hosted instance level buckets don't need a bucket policy for CoreWeave
  • CoreWeave buckets are specified by name in W&B, rather than bucket path. The full bucket path needs to be added to the environment variable before the bucket can be used for team storage.
  • Other small adjustments

Preview: https://docs-1630.docodile.pages.dev/guides/hosting/data-security/secure-storage-connector/

Ready for peer review

@mdlinville mdlinville requested a review from estellazx July 2, 2025 22:02
@mdlinville mdlinville requested a review from a team as a code owner July 2, 2025 22:02
@estellazx
Copy link
Contributor

hey @mdlinville those changes look good. Can we also remove the following from the docs?

  • CoreWeave: Set KMS key ARN to the CoreWeave ARN. we don't support this
  • and on the bottom in the FAQs the entire region error section as they don't even need to put in the region of their bucket
    • Region errors
      • CoreWeave AI Object Storage is not available in all regions.......

@estellazx
Copy link
Contributor

can we also make
cw://<accessKey>:<secretAccessKey>@cwobject.com/<bucketName>?tls=true not show up as a link? thanks!

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link
cloudflare-workers-and-pages bot commented Jul 3, 2025 •
edited
Loading

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a43c87b
Status: ✅  Deploy successful!
Preview URL: https://6926595b.docodile.pages.dev
Branch Preview URL: https://docs-1630.docodile.pages.dev

View logs

@mdlinville
Copy link
Contributor Author

can we also make cw://<accessKey>:<secretAccessKey>@cwobject.com/<bucketName>?tls=true not show up as a link? thanks!

This was a weird bug that doesn't happen in the other tabs! Now fixed, as well as your other feedback.

@mdlinville mdlinville requested a review from ngrayluna July 3, 2025 18:34
ngrayluna
ngrayluna reviewed Jul 3, 2025
View reviewed changes
ngrayluna
ngrayluna approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor
@ngrayluna ngrayluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR so it's not a blocker.

mdlinville and others added 2 commits July 3, 2025 15:42
@mdlinville @ngrayluna
Apply suggestions from code review
7d4701e 
Co-authored-by: Noah Luna <15202580+ngrayluna@users.noreply.github.com>
@mdlinville
Merge branch 'main' into DOCS-1630
a43c87b
@mdlinville mdlinville merged commit ed40737 into main Jul 3, 2025
4 checks passed
@mdlinville mdlinville deleted the DOCS-1630 branch July 3, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngrayluna ngrayluna ngrayluna approved these changes

@estellazx estellazx Awaiting requested review from estellazx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdlinville @estellazx @ngrayluna
0