8000 Refactor: Update many instances of http:// to https:// by mdlinville · Pull Request #1442 · wandb/docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor: Update many instances of http:// to https:// #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 9, 2025
Merged

Refactor: Update many instances of http:// to https:// #1442

merged 9 commits into from
Jul 9, 2025

Conversation

mdlinville
Copy link
Contributor
@mdlinville mdlinville commented Jul 8, 2025 •
edited
Loading

Fixes #1412 reported by @al-stev

Rather than fixing just the one typo, Cursor helped me to

  • Update instances of http:// to https:// in links after checking that the link works
  • Remove bold from around links
  • Remove some stray empty backticks I noticed
  • Add missing periods at the ends of sentences, and remove duplicated periods

Ready for review

@mdlinville mdlinville requested a review from ngrayluna July 8, 2025 19:46
@mdlinville mdlinville requested a review from a team as a code owner July 8, 2025 19:46
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link
cloudflare-workers-and-pages bot commented Jul 8, 2025 •
edited
Loading

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 671443b
Status: ✅  Deploy successful!
Preview URL: https://f2f212d7.docodile.pages.dev
Branch Preview URL: https://fix-http-https.docodile.pages.dev

View logs

mdlinville
mdlinville commented Jul 8, 2025
View reviewed changes
ngrayluna
ngrayluna reviewed Jul 8, 2025
View reviewed changes
Copy link
Contributor
@ngrayluna ngrayluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this also passes Lychee checks?

mdlinville and others added 2 commits July 8, 2025 16:14
@mdlinville @ngrayluna
Apply suggestions from code review
3af0ae8 
Co-authored-by: Noah Luna <15202580+ngrayluna@users.noreply.github.com>
@mdlinville
Merge branch 'main' into fix_http_https
fa156a1
@mdlinville
Copy link
Contributor Author

I assume this also passes Lychee checks?

Good point, running now: https://github.com/wandb/docs/actions/runs/16156358772

mdlinville
mdlinville commented Jul 8, 2025
View reviewed changes
@mdlinville
Copy link
Contributor Author

I assume this also passes Lychee checks?

Passing now!

@mdlinville mdlinville requested a review from ngrayluna July 8, 2025 23:19
@mdlinville mdlinville merged commit d811954 into main Jul 9, 2025
4 checks passed
@mdlinville mdlinville deleted the fix_http_https branch July 9, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngrayluna ngrayluna ngrayluna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

http typo?
2 participants
@mdlinville @ngrayluna
0