8000 feat(integrations): deprecate openai autolog integration for openai >= 1.0 by ayulockin · Pull Request #7033 · wandb/wandb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(integrations): deprecate openai autolog integration for openai >= 1.0 #7033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat(integrations): deprecate openai autolog integration for openai >= 1.0 #7033

wants to merge 8 commits into from

Conversation

ayulockin
Copy link
Member

Description

What does the PR do?

This PR adds a deprecation warning for the OpenAI autolog integration for openai >= 1.0.

It also kills the program when the openai >= 1.0 with a user friendly error message.

Testing

How was this PR tested?

@ayulockin ayulockin requested a review from a team as a code owner February 21, 2024 11:08
@codecov Codecov
Copy link
codecov bot commented Feb 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.68%. Comparing base (d6af7f7) to head (1a2557d).
Report is 1889 commits behind head on main.

Files with missing lines Patch % Lines
wandb/sdk/integration_utils/auto_logging.py 33.33% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7033      +/-   ##
==========================================
- Coverage   78.89%   77.68%   -1.21%     
==========================================
  Files         488      488              
  Lines       52401    52410       +9     
==========================================
- Hits        41341    40716     -625     
- Misses      10745    11383     +638     
+ Partials      315      311       -4
Flag Coverage Δ
func 47.25% <0.00%> (-1.68%) ⬇️
system 64.33% <0.00%> (-0.06%) ⬇️
unit 58.70% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
wandb/sdk/integration_utils/auto_logging.py 63.28% <33.33%> (-2.27%) ⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

timoffex
timoffex approved these changes Feb 24, 2024
View reviewed changes
Copy link
Contributor
@timoffex timoffex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this fails a precommit check. There's a generated file wandb_internal.rs that needs to be updated:

wandb/client/src/wandb_internal.rs

Lines 891 to 924 in 929ec40

#[allow(clippy::derive_partial_eq_without_eq)]
#[derive(Clone, PartialEq, ::prost::Message)]
pub struct Deprecated {
/// wandb.keras.WandbCallback(data_type=...) called
#[prost(bool, tag = "1")]
pub keras_callback_data_type: bool,
/// wandb.run.mode called
#[prost(bool, tag = "2")]
8000 pub run_mode: bool,
/// wandb.run.save() called without arguments
#[prost(bool, tag = "3")]
pub run_save_no_args: bool,
/// wandb.run.join() called
#[prost(bool, tag = "4")]
pub run_join: bool,
/// wandb.plots.* called
#[prost(bool, tag = "5")]
pub plots: bool,
/// wandb.run.log(sync=...) called
#[prost(bool, tag = "6")]
pub run_log_sync: bool,
/// wandb.init(config_include_keys=...) called
#[prost(bool, tag = "7")]
pub init_config_include_keys: bool,
/// wandb.init(config_exclude_keys=...) called
#[prost(bool, tag = "8")]
pub init_config_exclude_keys: bool,
/// wandb.keras.WandbCallback(save_model=True) called
#[prost(bool, tag = "9")]
pub keras_callback_save_model: bool,
/// wandb.integration.langchain.WandbTracer called
#[prost(bool, tag = "10")]
pub langchain_tracer: bool,
}

This is the diff that's suggested:

@@ -921,6 +921,9 @@ pub struct Deprecated {
     /// wandb.integration.langchain.WandbTracer called
     #[prost(bool, tag = "10")]
     pub langchain_tracer: bool,
+    /// wandb.integration.openai.autolog
+    #[prost(bool, tag = "11")]
+    pub openai_autolog: bool,
 }
 #[allow(clippy::derive_partial_eq_without_eq)]
 #[derive(Clone, PartialEq, ::prost::Message)]

@ayulockin
Copy link
Member Author
ayulockin commented Feb 26, 2024 •
edited by timoffex
Loading

Hey @timoffex, the pre-commit is not failing locally. Not sure what I should action? Should I manually update the [wandb_internal.rs](https://github.com/wandb/wandb/blob/929ec409ddc19ba3f4515e91ffe7848cefcc76bb/client/src/wandb_internal.rs#L891-L924) file?

@ayulockin - It's odd that the pre-commit is not failing locally; maybe you don't have some Rust tool installed. We should fix that on the SDK team... In the meantime, I think you have to make the change manually, since the check is failing in CI.

@tim 8000 offex
Copy link
Contributor

Oops, I edited your comment by accident...

@ayulockin ayulockin mentioned this pull request Mar 12, 2024
Closed
7 tasks
@kptkin kptkin removed the cc-feat label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timoffex timoffex timoffex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayulockin @timoffex @kptkin
0