10000 Use of possibly uninitialized variable body_chunk_len in lib/roles/h2/http2.c · Issue #3004 · warmcat/libwebsockets · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ libwebsockets Public
  • Notifications < 8000 tool-tip id="tooltip-f80830ae-aa1d-4d28-bacd-7659449ccf95" for="repository-details-watch-button" popover="manual" data-direction="s" data-type="description" data-view-component="true" class="sr-only position-absolute">You must be signed in to change notification settings
  • Fork 1.5k
  • Star 5k

Use of possibly uninitialized variable body_chunk_len in lib/roles/h2/http2.c #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
schuettecarsten opened this issue Nov 10, 2023 · 1 comment
Closed

Use of possibly uninitialized variable body_chunk_len in lib/roles/h2/http2.c #3004

schuettecarsten opened this issue Nov 10, 2023 · 1 comment

Comments

@schuettecarsten
Copy link
schuettecarsten commented Nov 10, 2023 •
edited
Loading

Use of uninitialized variable in lib/roles/h2/http2.c.
lws_filepos_t body_chunk_len is declared in line 2819 and used later, but might not be initialized.

Is it safe to simply initialize this with 0?
@schuettecarsten schuettecarsten mentioned this issue Nov 10, 2023
Closed
lws-team pushed a commit that referenced this issue Nov 10, 2023
@lws-team
clean: gcc13 false positive uninitialized
bfce9f8 
#3004
lws-team pushed a commit that referenced this issue Nov 10, 2023
@lws-team
clean: gcc13 false positive uninitialized
08ee6f1 
#3004
@lws-team
Copy link
Member

Thanks... we only try to use body_chunk_len if lws_h2_parser() returns 0 or 2. Going through lws_h2_parser(), every way out of it returning 0 or 2, sets body_chunk_len (it's passed in pointed-to by inused arg to lws_h2_parser()). So I believe this is a false positive.

FWIW F39 gcc 13.2 did not blow any errors AFAIK.

Of course, in terms of an error coming out of the compiler and killing the build, it doesn't make much odds, it still emits an error rightly or wrongly the same. But since it's wrong, we only need to help the compiler see it's wrong so just zeroing should be fine.

I pushed a patch doing that (and moving the declaration scope inside the loop) on main + v4.3-stable.

lws-team pushed a commit that referenced this issue Nov 24, 2023
@lws-team
clean: gcc13 false positive uninitialized
52597bf 
#3004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schuettecarsten @lws-team
0