Allow optional ConfigMap / Secrets #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelSpeed
reviewed
Aug 7, 2019
There was a problem hiding this comment.
Added some comments about consistency in naming, not too fussed about fixing them but if we can keep them consistent it would be nice!
For the optional CMs and Secrets it perhaps calling them optional-volume, optional-env, optional-envfrom? Does that make sense?
d4662d2 to
cd71562
Compare
JoelSpeed
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to specify Secrets and ConfigMaps as
optionalfor a Deployment (and potentially other resource types), and Wave appears to have support for this with regards to values in theEnvFromsection, but not when mounting a Secret or ConfigMap.This allows secrets and config maps mounted from a
Volume,EnvFromorEnvto be optional.