fix: refined swhks ipc.rs for hash calculation and finding buffer byte #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit attempts at fixing the major issue of rfkill not being properly turned off while creating the swhkd virtual device. Changes made: 1. Added RfkillEvent struct that stores the rfkill details and status required with documentation 2. Added two new macros with `ioctl_readwrite` to ensure that we can query the rfkill status and modify properly 3. New function `unblock_rfkill` that unblocks all soft blocks for any device 4. Called `unblock_rfkill` function in `create_uinput_switches_device` that ensures that rfkill is NOT blocked and complies with rfkill-input being disabled This should ensure that rfkill does not react when virtual device is being created.
1. Calculate hash function now borrows the string instead of taking ownership 2. Used match to check for buffer byte instead of if statement 3. Added more debug logging and error handling
Remove updated logic for uinput.rs as it does not work
replaced `map_for` with `is_some_and` as it is more efficient in this case (simple bool ops)
newtoallofthis123
approved these changes
Mar 26, 2025
|
Looks good to me and I've tested it on my local machine |
|
Looks good. I haven't tested so I'm relying on your findings. @newtoallofthis123 Go ahead with merge. |
Sign up for free
to join this conversation on GitHub.
Already
5A34
have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
ownership
In
swhkd/src/daemon.rs:map_forwithis_some_andas it is more efficient in thiscase (simple bool ops)
This PR was tested with:
make testNote:
I tried to modify
uinput.rsto fix the rfkill issue but the logic did not really work so I had to fallback to the latest commit on swhkd (kindly ignore it)I did not create any new tests as I just modified functional logic only.