10000 Changes the implementation of accumulated predictions (prevents underflow in some cases) by TimPaquaij · Pull Request #9 · wdika/atommic · GitHub

More Web Proxy on the site http://driver.im/

Changes the implementation of accumulated predictions (prevents underflow in some cases) #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

TimPaquaij wants to merge 1 commit into wdika:main from TimPaquaij:weighted-loss

TimPaquaij commented

What does this PR do?

Fixes issues related to underflow by changing the accumulation approach. Also added an option to perform accumulate predictions on segmentation.

Collection: Multi-task

Changelog

Initial implementation

loss = sum(x * w for x, w in zip(rs_cascades_loss, rs_cascades_weights)) / len(prediction)

Advised implementation

loss = sum(x * w for x, w in zip(rs_cascades_loss, rs_cascades_weights)) / sum(rs_cascades_weights)

Weighted average

Since the individual weights are =< 1 dividing the weighted sum by the number of predictions results in a diminishing of the loss. Especially when performing the average weighted 3 times in the MTLRS.

Usage

You can potentially add a usage example below

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)


          initial commit weighted loss

66f9972

**.DS_Store

Changed test script for accumulate

test_script check and is working

Update base.py process_segmentation_loss

Update mtlrs

update test_mtlrs.py

update requirements.txt

Update base.py

fixes style base.py

github-actions bot added the MTL label

github-actions bot commented

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions bot added the Stale label

github-actions bot commented

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions bot closed this

wdika reopened this

github-actions bot removed the Stale label

github-actions bot commented

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions bot added the Stale label

github-actions bot commented

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions bot closed this

wdika reopened this

github-actions bot removed the Stale label

github-actions bot commented

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions bot added the Stale label

github-actions bot commented

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions bot closed this

wdika reopened this

github-actions bot removed the Stale label

github-actions bot commented

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions bot added the Stale label

github-actions bot commented

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions bot closed this

wdika reopened this

github-actions bot removed the Stale label

github-actions bot commented

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions bot added the Stale label

github-actions bot commented

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions bot closed this

wdika reopened this

wdika added help wanted and removed Stale labels

github-actions bot commented

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions bot added the Stale label

wdika removed the Stale label

github-actions bot commented

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions bot added the Stale label

github-actions bot commented

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions bot closed this

wdika removed the Stale label

wdika reopened this

github-actions bot commented

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions bot added the Stale label

wdika removed the Stale label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted MTL

0