8000 Update pod status to terminating by slalwani97 · Pull Request #3729 · weaveworks/scope · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update pod status to terminating #3729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

slalwani97
Copy link
Contributor
  • kubectl way -
if pod.DeletionTimestamp != nil {
	reason = "Terminating"
}

Fixes: #3554

image

Signed-off-by: Sumit Lalwani sumit.lalwani97@gmail.com

Signed-off-by: Sumit Lalwani <sumit.lalwani97@gmail.com>
Copy link
Contributor
@qiell qiell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator
@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bboreham bboreham merged commit 5dc8332 into weaveworks:master Nov 26, 2019
@slalwani97 slalwani97 deleted the update-terminating-state branch November 26, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report 'Terminating' pod status better
3 participants
0