8000 Fix in WeaveDNS: do not modify cache when getting a reply by inercia · Pull Request #532 · weaveworks/weave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

Fix in WeaveDNS: do not modify cache when getting a reply #532

Merged
merged 5 commits into from
Apr 13, 2015
Merged

Fix in WeaveDNS: do not modify cache when getting a reply #532

merged 5 commits into from
Apr 13, 2015

Conversation

inercia
Copy link
Contributor
@inercia inercia commented Apr 9, 2015

Changes in this PR:

  • do not modify the TTL in the reply stored when Getting from the cache
  • set all responses obtained with mDNS as authoritative
  • minor improvements in the logs

Note: this PR depends on #501

@awh
Copy link
Contributor
awh commented Apr 13, 2015

Thankyou for splitting this up it's much much easier to digest! LGTM.

awh added a commit that referenced this pull request Apr 13, 2015
@awh
Merge pull request #532 from inercia/weave-225-fix-2
7f434d7 
Fix in WeaveDNS: do not modify cache when getting a reply
@awh awh merged commit 7f434d7 into weaveworks:master Apr 13, 2015
@inercia
Copy link
Contributor Author
85E5 inercia commented Apr 13, 2015

Great. Thanks for the reviews @awh

@inercia inercia deleted the weave-225-fix-2 branch April 13, 2015 13:21
@rade rade modified the milestone: 0.10.0 Apr 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@inercia @awh @rade
0