8000 Handle the case where Forward returns nil by dpw · Pull Request #1668 · weaveworks/weave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

Handle the case where Forward returns nil #1668

Closed
wants to merge 1 commit into from
Closed

Handle the case where Forward returns nil #1668

wants to merge 1 commit into from

Conversation

dpw
Copy link
Contributor
@dpw dpw commented Nov 11, 2015

Forward can return nil if the remote peer has HasShortID false. That
can happen if we learn about a 1.2 peer from a 1.1 peer and attempt to
connect to it.

This change just fixes the panic. HasShortID will never be set, so we'll
fall back to sleeve. But if that occurs, if can be fixed by a restart of
the affected routers.

Addresses #1661.

@dpw
Handle the case where Forward returns nil
7dc1b50 
Forward can return nil if the remote peer has HasShortID false.  That
can happen if we learn about a 1.2 peer from a 1.1  peer and attempt to
connect to it.

This change just fixes the panic.  HasShortID will never be set, so we'll
fall back to sleeve.  But if that occurs, if can be fixed by a restart of
the affected routers.
@rade
Copy link
Member
rade commented Nov 11, 2015

needs to be re-PR'ed against 1.2

@dpw dpw closed this Nov 11, 2015
@rade rade modified the milestone: 1.2.2 Nov 11, 2015
@awh awh modified the milestones: 1.2.2, 1.3.0 Nov 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dpw @rade @awh
0