This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Remove 'nameserver' option from plugin #1777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6759841 to
42bfeb3
Compare
|
More thought is required; maybe we should be using this option; maybe it is required in some sub-mode of plugin operation. Maybe |
|
Note that, even if we did want this route, Docker 1.10 overrides our choice of DNS server. |
|
LGTM; needs rebase. |
42bfeb3 to
e4828ad
Compare
|
Rebased |
awh
added a commit
that referenced
this pull request
Jan 29, 2016
Remove 'nameserver' option from plugin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot b
2F0E
e applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't seem to be using it.
Extracted from #1738 to simplify it; this change can be applied at a later date.