This repository was archived by the owner on Jun 20, 2024. It is now read-only.
fix gossip test connection peer initialisation and connection deletion mistakes #1796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were creating peers with NewPeerFrom, which copies the Version (but not connections). That's not what happens for a real connection, where remote peers are always created with an initial version of 0. The mistake results in brokenness: when we subsequently receive a topology update for that peer with the same version then we ignore it, even though the update contains connection information which is new to us. Related, it is conceptually wrong to call FetchWithDefault on the remote router. That is not what happens for a real connection - the FetchWithDefault occurs in the symmetric counterpart.
Also change Start() order in AddTestGossipConnection to be more pleasing to the eye; the order isn't actually important.
This is a one-sided operation, so we shouldn't be touching the remote's Peers. Also fix the associated test... When both 1 and 2 have lost their connection to 3, they no longer have a route to 3 and hence gc it. And because they no longer have a route, gossip from them won't get through to 3.
bboreham
added a commit
that referenced
this pull request
Dec 16, 2015
fix gossip test connection peer initialisation and connection deletion mistakes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3E50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.