This repository was archived by the owner on Jun 20, 2024. It is now read-only.
clean up GossipSender #1826
Merged
clean up GossipSender #1826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f240ee to
dc1ebb0
Compare
dc1ebb0 to
9702faf
Compare
In particular don't require Send() to be serialised by the caller. We split up the triple(!) purpose 'cell' channel into: 1) a 'cell' member, holding pending GossipData or nil 2) a 'more' channel, for signalling that 'cell' has been filled 3) a 'stop' channel, for requesting termination
which has a very narrow purpose, and can use 'defer' to release the lock, which is nice.
9702faf to
e952021
Compare
|
LGTM; has anything come up on this in the 13 days since last update? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for explanation.