This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Support subnet and iprange arguments on network create #1915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ip.Mask = subnet.Mask // fix up the subnet we lied about | ||
| } else { | ||
| err = fmt.Errorf("Unrecognized pool ID: %s", poolID) | ||
| } |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
6a43ca9 to
cc8af49
Compare
|
Added documentation and squashed commits |
cc8af49 to
1a59734
Compare
rade
added a commit
that referenced
this pull request
Jan 22, 2016
Support subnet and iprange arguments on network create Closes #1806.
| containers attached to them will be able to communicate with | ||
| containers attached to `weave`; there is no isolation between those | ||
| networks. | ||
| $ docker network create --driver=weavemesh --ipam-driver=weavemesh --subnet=<subnet> <network-name> |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this sugges
2FF4
tion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1806
It is perhaps cheating to get Docker to store the info we need, smuggled inside the pool name. But I don't see any reason why it should break.