This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Return an error when weave isn't running, on RequestPool #1918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't do anything particularly useful to fix the issue in 1.4. The plugin is still dying there (and getting restarted by docker), and no error shows up in the tty. |
awh
added a commit
that referenced
this pull request
Feb 2, 2016
Return an error when weave isn't running, on RequestPool
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1906.
When I did just the simple fix, I got "invalid CIDR address" back from Docker, which suggested the error wasn't being propagated correctly, hence the other two commits.