This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Negative fragment fix #1926
Merged
Negative fragment fix #1926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current minimum PMTU we can detect is eight bytes, which, being lower than the minimum IPv4 MTU of 68 bytes, can cause an exception in the sleeve packet fragmentation implementation. We increase that minimum to 552, the lowest PMTU value that Linux will cache.
The assumptions on which this test was based were violated by the introduction of fast datapath. A new rule is required to block fast datapath traffic, to ensure that sleeve is selected for forwarding; the rules must also be moved from the FORWARD chain to INPUT as the router now runs in the host netns (NB we use INPUT instead of OUTPUT as the latter results in sleeve receiving an 'operation not permitted' udpv4 write error when it tries to send a packet that is too big, rather than the packet just being silently dropped as required)
rade
added a commit
that referenced
this pull request
Jan 26, 2016
Negative fragment fix Fixes #1905.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1905.