This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Periodically check for up to date versions of weave. #1954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79683c7 to
9b38721
Compare
9b38721 to
b252524
Compare
|
Leaving aside whether this is a good idea in principle..., I see the following issues:
|
| @@ -55,6 +55,12 @@ For installing weave on other platforms, follow the [integration guides](http:// | |||
| Weave respects the environment variable `DOCKER_HOST`, so you can run | |||
| it locally to control a weave network on a remote host. | |||
|
|
|||
| Weave will periodically check with our servers to see if a new version is available. To disable this, run: | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
b252524 to
f2b9c07
Compare
|
I've addressed 1-3. I'd like to leave 4 as is. |
1f1e1d6 to
c292e46
Compare
| params := checkpoint.CheckParams{ | ||
| Product: "weave-net", | ||
| Version: version, | ||
| SignatureFile: "", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
c292e46 to
ea3f4e3
Compare
|
@awh have fixed in weaveworks/go-checkpoint#1 and updated here. PTAL. |
| [submodule "vendor/github.com/weaveworks/go-checkpoint"] | ||
| path = vendor/github.com/weaveworks/go-checkpoint | ||
| url = https://github.com/weaveworks/go-checkpoint | ||
| [submodule "vendor/github.com/certifi/gocertifi"] |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
e7624a1 to
1895ea0
Compare
1895ea0 to
b79bb32
Compare
|
@tom this appears to have a file descriptor leak. Here's a Then, 30s later, more traffic (HTTP keepalive?). The HTTPS connection to checkpoint-api.weave.works is still ESTABLISHED on the weave host: A minute after launch, we get a FIN from the checkpoint API (which we ACK): But no FIN in the other direction. HTTPS connection is now in CLOSE_WAIT on the weave host. Then forever more: Ten minutes have elapsed. On weave host: Best case is that this gets cleaned up the next time we check; if not, we'll leak file descriptors until we run out. Either way, having this suspicious looking connection hanging around isn't ideal 😄 Looks like |
|
@awh weaveworks/go-checkpoint#2 should fix that. Thanks for the testing! |
|
👍 |
awh
added a commit
that referenced
this pull request
Feb 26, 2016
Periodically check for up to date versions of weave.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every 6 hours, hit https://checkpoint-api.weave.works looking for current versions of Weave. If a new version is found, log it.
Reuses the same library as Hashicorp's products.