8000 Persist 'owned' addresses in IPAM by bboreham · Pull Request #1973 · weaveworks/weave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

Persist 'owned' addresses in IPAM #1973

Merged
merged 2 commits into from
Mar 3, 2016
Merged

Persist 'owned' addresses in IPAM #1973

merged 2 commits into from
Mar 3, 2016

Conversation

bboreham
Copy link
Contributor

New take on #1945, following on from #1971

Here we are serializing the entire set every time it changes, which is overkill, but we don't expect the set to have more than 1,000 entries on one host and we don't expect it to change more than ~10 times per second.

@bboreham bboreham force-pushed the issues/678-persist-owned2 branch from 6208c6c to 3b2d774 Compare February 12, 2016 18:15
@awh awh mentioned this pull request Feb 15, 2016
Closed
@bboreham bboreham self-assigned this Feb 27, 2016
@bboreham bboreham force-pushed the issues/678-persist-owned2 branch 3 times, most recently from 8c63387 to 21d67d4 Compare February 28, 2016 02:49
@bboreham
Copy link
Contributor Author

I removed the test for addresses added with weave attach; it requires serious modification to proxy startup to be able to attach containers started outside of the proxy. I think we can ship 1.5 without that feature.

@bboreham bboreham added this to the 1.5.0 milestone Feb 28, 2016
@bboreham bboreham removed their assignment Feb 29, 2016
@awh awh self-assigned this Feb 29, 2016
awh
awh reviewed Mar 1, 2016
View reviewed changes
test/163_docker_restart_test.sh
start_suite "Containers get same IP address on restart"

# Remove any persisted data from previous runs
run_on $HOST1 "sudo rm -f /tmp/test645-*"

This comment was marked as abuse.

Sign in to view

@bboreham bboreham force-pushed the issues/678-persist-owned2 branch from 21d67d4 to 0b0d244 Compare March 1, 2016 22:06
@bboreham
Copy link
Contributor Author
bboreham commented Mar 1, 2016

I have rebased, fixed the test directory name, and moved half the commits out to #2012

@bboreham bboreham mentioned this pull request Mar 1, 2016
Merged
@bboreham bboreham force-pushed the issues/678-persist-owned2 branch from cb1bd1b to 95cbc89 Compare March 2, 2016 19:35
bboreham added a commit that referenced this pull request Mar 3, 2016
@bboreham
Merge pull request #1973 from /issues/678-persist-owned2
4c159a9 
Persist 'owned' addresses in IPAM
@bboreham bboreham merged commit 4c159a9 into master Mar 3, 2016
@bboreham bboreham mentioned this pull request Mar 3, 2016
Closed
@rade rade deleted the issues/678-persist-owned2 branch March 19, 2016 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@awh awh

Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bboreham @awh
0