8000 Implement `weave consense` by awh · Pull Request #1997 · weaveworks/weave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

Implement weave consense #1997

Merged
merged 1 commit into from
Mar 3, 2016
Merged

Implement weave consense #1997

merged 1 commit into from
Mar 3, 2016

Conversation

awh
Copy link
Contributor
@awh awh commented Feb 24, 2016

Fixes #1994.

@awh awh added this to the 1.5.0 milestone Feb 24, 2016
@bboreham bboreham force-pushed the issues/1994-weave-consense branch from e52b015 to d170110 Compare March 2, 2016 01:42
@bboreham
Copy link
Contributor
bboreham commented Mar 2, 2016

I rebased this against master

@awh
Copy link
Contributor Author
awh commented Mar 2, 2016

I rebased this against master

Any comments @bboreham?

Docs deliberately missing from this PR to avoid clashing with the documentation restructuring - will add some after that has merged.

@rade
Copy link
Member
rade commented Mar 2, 2016

Docs deliberately missing from this PR to avoid clashing with the documentation restructuring - will add some after that has merged.

Please don't defer updating the docs.

@bboreham
Copy link
Contributor
bboreham commented Mar 2, 2016

I guess we could have done this with a dummy allocation for a zero-size range, to avoid a new queue and data type.

But no specific complaints about the way you did it.

DEB4 @awh awh force-pushed the issues/1994-weave-consense branch from d170110 to bc70e73 Compare March 3, 2016 15:43
@awh
Copy link
Contributor Author
awh commented Mar 3, 2016

I guess we could have done this with a dummy allocation for a zero-size range, to avoid a new queue and data type.

I did consider it, but I felt it was cleaner to have a proper operation for it.

Rebased on master + added some docs.

@awh awh force-pushed the issues/1994-weave-consense branch 2 times, most recently from 779f75e to 399bd1c Compare March 3, 2016 17:13
@awh awh force-pushed the issues/1994-weave-consense branch from 399bd1c to 6584df2 Compare March 3, 2016 18:52
bboreham added a commit that referenced this pull request Mar 3, 2016
@bboreham
Merge pull request #1997 from /issues/1994-weave-consense
b83f4a0 
Implement `weave consense`
@bboreham bboreham merged commit b83f4a0 into master Mar 3, 2016
@rade rade deleted the issues/1994-weave-consense branch March 19, 2016 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@awh @bboreham @rade
0