This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Abstract out logging function from weave api package #2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3276fea to
f381eed
Compare
f381eed to
f2e38ae
Compare
|
@peterbourgon I would like to get your take on this. I haven't seen any go libraries where logging is configured the way proposed here. Have you? Do you reckon it's ok to do this? Are there better approaches? |
|
Loggers are dependencies, so a strong 👍 from me to pass a logger into your constructors. Plenty of other packages do this or something like it; the only improvement I could suggest is making it optional, but in order to do that in this usage, we'd need to complect the API, either using multiple constructors or introducing a config object with a usable zero value. In either case, probably not worth it. |
rade
added a commit
that referenced
this pull request
Mar 9, 2016
Abstract out logging function from weave api package
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce dependencies for other projects who decide to use the Weave Net API. With this change, you have to pass in the logger you want to use when you create the
Clientobject.The
Loggerinterface here is a bit arbitrary; the only function we are actually using isDebugf, but it seemed a bit weird to just have that one line.