This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Fix missed errors in weave script #2054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -948,7 +948,7 @@ args_match() { | |||
| prev_args="$(docker inspect -f '{{.Args}} {{.Config.Env}}' $1)" | |||
| shift | |||
| dummy_container=$(docker create "$@" 2>/dev/null) || return 1 | |||
| dummy_args="$(docker inspect -f '{{.Args}} {{.Config.Env}}' $dummy_container)" | |||
| dummy_args="$(docker inspect -f '{{.Args}} {{.Config.Env}}' $dummy_container)" || return 1 | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
We cannot rely on `set -e` to fail the whole script in contexts where functions are called inside conditionals.
b79dcdb to
0705319
Compare
rade
added a commit
that referenced
this pull request
Mar 17, 2016
Fix missed errors in weave script Fixes #2053.
rade
added a commit
that referenced
this pull request
Mar 17, 2016
...for calling in a context w/o 'set -e', even though right now they always are. Follow-on of #2054.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2053
Return failure from various functions when sub-operation fails.
We cannot rely on
set -eto fail the whole script in contexts where functions are called inside conditionals.