This repository was archived by the owner on Jun 20, 2024. It is now read-only.
make weave rmpeer accept a list of peers
#2075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't as efficient as it could be. In particular we end up broadcasting the ipam state for every peer listed. To avoid that we'd have to change the HTTP API, and would no longer be able to use 'DELETE'. That is just not worth it. Closes #2044.
awh
added a commit
that referenced
this pull request
Mar 21, 2016
make `weave rmpeer` accept a list of peers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't as efficient as it could be. In particular we end up broadcasting the ipam state for every peer listed. To avoid that we'd have to change the HTTP API, and would no longer be able to use 'DELETE'. That is just not worth it.
Closes #2044.