This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Override stale dns entries received via gossip #2081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -105,6 +108,11 @@ func (e1 *Entry) addLowercase() { | |||
| e1.lHostname = strings.ToLower(e1.Hostname) | |||
| } | |||
|
|
|||
| func (e *Entry) makeTombstone() { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
I have covered all the points raised, but note weaveworks/mesh#28 means the data does not propagate until periodic gossip fires. |
| gossip.Entries.filter(func(e *Entry) bool { | ||
| return n.isKnownPeer(e.Origin) | ||
| if e.Origin == n.ourName { | ||
| n.infof("Received entry like mine: %v", e) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Updated again, with smoke-test working. See weaveworks/mesh#29 |
| if isRestartedPeer { | ||
| conn.Log("connection added (restarted peer)") | ||
| peer.router.SendAllGossipDown(conn) | ||
| } else if isConnectedPeer { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Let's leave out the mesh changes; too dangerous for 1.4.6. |
aef8c1d to
c2cf825
Compare
|
Removed mesh changes, squashed commits |
rade
added a commit
that referenced
this pull request
Apr 6, 2016
Update weaveworks/mesh to send gossip to restarted peer Fixes #2085.
rade
added a commit
that referenced
this pull request
Apr 6, 2016
Immediately broadcast DNS records that "re-assert a peer's authority"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1867 and #2023.
Also makes the merging of tombstones stable, where everything else is equal.