8000 2057: Add allocator.PeerGone by brb · Pull Request #2205 · weaveworks/weave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

2057: Add allocator.PeerGone #2205

Merged
merged 1 commit into from
Apr 22, 2016
Merged

2057: Add allocator.PeerGone #2205

merged 1 commit into from
Apr 22, 2016

Conversation

brb
Copy link
Contributor
@brb brb commented Apr 22, 2016

The function is registered within the mesh GC and it is responsible
for removing gone nicknames.

Fixes #2057

@rade
Copy link
Member
rade commented Apr 22, 2016

I am not convinced the test code is worth having. Not enough bang for buck.

@brb brb force-pushed the issues/2057-gc-nicknames branch from 4bb14f2 to 7b41e70 Compare April 22, 2016 13:42
@brb
Copy link
Contributor Author
brb commented Apr 22, 2016

Added a simplified version of TestPeerGone, although personally I don't like that alloc.nicknames gets directly modified in the test.

If you are happy with it, I will squash my commits and get rid of the previous version.

@brb
Add allocator.PeerGone
849edb1 
The function is registered within the mesh gc and it is responsible
for removing gone nicknames (#2057).
@brb brb force-pushed the issues/2057-gc-nicknames branch from 8848b63 to 849edb1 Compare April 22, 2016 16:29
@rade rade added this to the 1.6.0 milestone Apr 22, 2016
@rade rade merged commit cec88f1 into master Apr 22, 2016
@awh awh deleted the issues/2057-gc-nicknames branch May 6, 2016 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
[component/ipam]
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@brb @rade
0