8000 Improve doc CI by awh · Pull Request #2274 · weaveworks/weave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

Improve doc CI #2274

Merged
merged 9 commits into from
Oct 3, 2016
Merged

Improve doc CI #2274

merged 9 commits into from
Oct 3, 2016

Conversation

awh
Copy link
Contributor
@awh awh commented May 10, 2016

Fixes #2273.

@awh awh added this to the 1.5.2 milestone May 10, 2016
@awh awh force-pushed the issues/2273-improve-doc-ci branch 7 times, most recently from c563dfb to 409461b Compare May 10, 2016 15:38
@awh awh self-assigned this May 10, 2016
@awh awh force-pushed the issues/2273-improve-doc-ci branch 2 times, most recently from 8fcf9c2 to dac30c6 Compare May 11, 2016 16:01
@awh
Copy link
Contributor Author
awh commented May 11, 2016 •
edited
Loading

This is an example comment of the type generated by this PR

Documentation changes:

added foo
modified ipam
removed using-weave/host-network-integration
removed using-weave/manual-ip-address

@awh awh force-pushed the issues/2273-improve-doc-ci branch from dac30c6 to 838bd01 Compare May 11, 2016 16:09
@awh awh removed their assignment May 11, 2016
@bboreham bboreham self-assigned this May 12, 2016
bboreham
bboreham reviewed May 12, 2016
View reviewed changes
circle.yml
parallel: true
- cd $SRCDIR/test; ./gce.sh setup && eval $(./gce.sh hosts) && ./setup.sh:
pre:
- "$SRCDIR/bin/circle-test-pre":

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@bboreham
Copy link
Contributor

More generally, I think the various shell-scripts added here should be given names like "unit-tests", "smoke-tests", "setup-build", etc., so that when you look in the CircleCI viewer at the steps or the timeline it is immediately apparent what each part is.

bboreham
bboreham reviewed May 12, 2016
View reviewed changes
bin/circle-deploy-master
cd /home/ubuntu/src/github.com/weaveworks/wordepress
git checkout v1.0.0
cd cmd/wordepress
go get

This comment was marked as abuse.

Sign in to view

@bboreham
Copy link
Contributor

Good improvements, but can be made even better.

@bboreham bboreham assigned awh and unassigned bboreham May 12, 2016
@bboreham
Copy link
Contributor

BTW I suspect that putting multiple steps into one script speeds up the build, because it allows differences in timing between CircleCI containers to even out over a longer interval, rather than waiting at each step for the other to catch up.

@bboreham bboreham modified the milestones: 1.5.2, 1.5.3 May 26, 2016
@bboreham bboreham mentioned this pull request Jun 6, 2016
Closed
@awh
Copy link
Contributor Author
awh commented Jun 13, 2016 •
edited
Loading

More generally, I think the various shell-scripts added here should be given names like "unit-tests", "smoke-tests", "setup-build", etc., so that when you look in the CircleCI viewer at the steps or the timeline it is immediately apparent what each part is.

The scripts were named to match the circle.yml steps 1:1 so it would be clear where you were adding something when you edited them. However, I concede that reading the output of test runs is a much more frequent activity than fiddling with the CI setup, so I will optimise for that instead.

@abuehrle
Copy link
Contributor

We will need to test this with the new website as well to make sure everything still works as expected. At the moment, please don't push anything to dev until the overhaul is complete.

@awh awh modified the milestones: icebox, 1.6.1 Jul 12, 2016
@awh awh force-pushed the issues/2273-improve-doc-ci branch 2 times, most recently from 1a9d7b4 to d323431 Compare September 29, 2016 11:17
@awh awh force-pushed the issues/2273-improve-doc-ci branch from d323431 to 835b3f3 Compare September 29, 2016 12:02
@awh awh changed the base branch from 1.5 to 1.7 September 29, 2016 13:09
@awh
Copy link
Contributor Author
awh commented Sep 29, 2016

Comments addressed; PTAL @bboreham

@awh awh removed their assignment Sep 29, 2016
@awh awh modified the milestones: 1.7.1, icebox Sep 29, 2016
@bboreham bboreham self-assigned this Oct 3, 2016
bboreham
bboreham reviewed Oct 3, 2016
View reviewed changes
Copy link
Contributor
@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L mostly GTM but I had a few comments/questions

bin/circle-dependencies-post
echo "PR touches [$FILES]"
if ! echo "$FILES" | grep -v ^site/ ; then
echo "PR contains site changes only - skipping tests"
echo "SKIP_TESTS=1" >> "$STATE"
8000

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

bin/circle-functions
@@ -0,0 +1,9 @@
#!/bin/bash

install_wordepress() {

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

bin/circle-deploy-release

set -e

source "$(dirname "$(readlink -f "$0")")/circle-functions"

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

bin/circle-deploy-master
make publish
fi

install_wordepress v1.0.0

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@bboreham bboreham assigned awh and unassigned bboreham Oct 3, 2016
@awh awh assigned bboreham and unassigned awh Oct 3, 2016
@awh
Copy link
Contributor Author
awh commented Oct 3, 2016

PTAL @bboreham

@bboreham bboreham merged commit e7c9e22 into 1.7 Oct 3, 2016
@awh awh deleted the issues/2273-improve-doc-ci branch October 5, 2016 13:24
@rade rade mentioned this pull request Oct 7, 2016
Closed
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bboreham bboreham bboreham left review comments

Assignees

@bboreham bboreham

Labels
None yet
Projects
None yet
Milestone
1.7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@awh @bboreham @abuehrle
0